TaskScheduler: Nits in service thread and delayed tasks code.

TaskScheduler: Nits in service thread and delayed tasks code.

BUG=553459
Committed: https://crrev.com/a6fc23c98a7244e563c6904f75dd43cb2723ace0
Cr-Commit-Position: refs/heads/master@{#426166}

[fdoray, 2016-10-18 20:10:21]

fdoray@chromium.org changed reviewers:
+ gab@chromium.org, robliao@chromium.org

[fdoray, 2016-10-18 20:10:21]

PTAL

[robliao, 2016-10-18 20:21:43]

lgtm

https://codereview.chromium.org/2426813004/diff/1/base/task_scheduler/task_sc...
File base/task_scheduler/task_scheduler_impl.cc (right):

https://codereview.chromium.org/2426813004/diff/1/base/task_scheduler/task_sc...
base/task_scheduler/task_scheduler_impl.cc:104: const
SchedulerWorkerPoolImpl::ReEnqueueSequenceCallback
What the motivation for this reordering?

[gab, 2016-10-18 20:50:40]

lgtm

https://codereview.chromium.org/2426813004/diff/1/base/task_scheduler/task_sc...
File base/task_scheduler/task_scheduler_impl.cc (right):

https://codereview.chromium.org/2426813004/diff/1/base/task_scheduler/task_sc...
base/task_scheduler/task_scheduler_impl.cc:104: const
SchedulerWorkerPoolImpl::ReEnqueueSequenceCallback
On 2016/10/18 20:21:43, robliao wrote:
> What the motivation for this reordering?

It's only required below and |delayed_task_manager| is related to
|service_thread_| created before it so both this being here makes sense and
|delayed_task_manager|'s init moving up.

[fdoray, 2016-10-18 21:03:31]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2016-10-18 21:04:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 23:37:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 23:37:58]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[fdoray, 2016-10-19 12:11:34]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2016-10-19 12:12:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 13:04:47]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-21 13:07:33]

Description was changed from

==========
TaskScheduler: Nits in service thread and delayed tasks code.

BUG=553459
==========

to

==========
TaskScheduler: Nits in service thread and delayed tasks code.

BUG=553459

Committed: https://crrev.com/a6fc23c98a7244e563c6904f75dd43cb2723ace0
Cr-Commit-Position: refs/heads/master@{#426166}
==========

[commit-bot: I haz the power, 2016-10-21 13:07:34]

Patchset 1 (id:??) landed as
https://crrev.com/a6fc23c98a7244e563c6904f75dd43cb2723ace0
Cr-Commit-Position: refs/heads/master@{#426166}