Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayerScrollableAreaTest.cpp

Issue 2426793002: Aura overlay scrollbars adjust color for dark backgrounds (Closed)
Patch Set: fix test Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/PaintLayerScrollableAreaTest.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintLayerScrollableAreaTest.cpp b/third_party/WebKit/Source/core/paint/PaintLayerScrollableAreaTest.cpp
index 26b0166a28e869154346572b42aef93e7f0f642c..0e08a5e2d2ba1593c39f47d5765563a1a285e384 100644
--- a/third_party/WebKit/Source/core/paint/PaintLayerScrollableAreaTest.cpp
+++ b/third_party/WebKit/Source/core/paint/PaintLayerScrollableAreaTest.cpp
@@ -9,6 +9,7 @@
#include "core/layout/LayoutTestHelper.h"
#include "core/paint/PaintLayer.h"
#include "platform/graphics/GraphicsLayer.h"
+#include "platform/scroll/ScrollTypes.h"
#include "platform/testing/RuntimeEnabledFeaturesTestHelpers.h"
namespace blink {
@@ -370,4 +371,39 @@ TEST_F(PaintLayerScrollableAreaTest, OnlyOpaqueLayersPromoted) {
EXPECT_FALSE(paintLayer->needsCompositedScrolling());
EXPECT_FALSE(paintLayer->graphicsLayerBacking());
}
+
+// Ensure OverlayScrollbarColorTheme get updated when page load
+TEST_F(PaintLayerScrollableAreaTest, OverlayScrollbarColorThemeUpdated) {
+ setBodyInnerHTML(
+ "<style>"
+ "div { overflow: scroll; }"
+ "#white { background-color: white; }"
+ "#black { background-color: black; }"
+ "</style>"
+ "<div id=\"none\">a</div>"
+ "<div id=\"white\">b</div>"
+ "<div id=\"black\">c</div>");
+ document().view()->updateAllLifecyclePhases();
+
+ Element* none = document().getElementById("none");
+ Element* white = document().getElementById("white");
+ Element* black = document().getElementById("black");
+
+ PaintLayer* noneLayer = toLayoutBoxModelObject(none->layoutObject())->layer();
+ PaintLayer* whiteLayer =
+ toLayoutBoxModelObject(white->layoutObject())->layer();
+ PaintLayer* blackLayer =
+ toLayoutBoxModelObject(black->layoutObject())->layer();
+
+ ASSERT_TRUE(noneLayer);
+ ASSERT_TRUE(whiteLayer);
+ ASSERT_TRUE(blackLayer);
+
+ ASSERT_EQ(ScrollbarOverlayColorTheme::ScrollbarOverlayColorThemeDark,
+ noneLayer->getScrollableArea()->getScrollbarOverlayColorTheme());
+ ASSERT_EQ(ScrollbarOverlayColorTheme::ScrollbarOverlayColorThemeDark,
+ whiteLayer->getScrollableArea()->getScrollbarOverlayColorTheme());
+ ASSERT_EQ(ScrollbarOverlayColorTheme::ScrollbarOverlayColorThemeLight,
+ blackLayer->getScrollableArea()->getScrollbarOverlayColorTheme());
+}
}

Powered by Google App Engine
This is Rietveld 408576698