third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlay.cpp - Issue 2426793002: Aura overlay scrollbars adjust color for dark backgrounds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlay.cpp

Issue 2426793002: Aura overlay scrollbars adjust color for dark backgrounds (Closed)

Patch Set: add test and remove dead code Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.mm ('k') | third_party/WebKit/Source/web/AssertMatchingEnums.cpp » ('j') | ui/native_theme/native_theme_aura.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlay.cpp

diff --git a/third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlay.cpp b/third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlay.cpp

index ed95ef9da96d7e9a04faeb27a7477c5350655248..b60cfbcbfbea6ef5c5a60358ba6299897314ea72 100644

--- a/third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlay.cpp

+++ b/third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlay.cpp

@@ -162,8 +162,13 @@ void ScrollbarThemeOverlay::paintThumb(GraphicsContext& context,

if (scrollbar.orientation() == VerticalScrollbar)

part = WebThemeEngine::PartScrollbarVerticalThumb;

+ blink::WebThemeEngine::ExtraParams params;

+ params.scrollbarThumb.scrollbarTheme =

+ static_cast<WebScrollbarOverlayColorTheme>(

+ scrollbar.getScrollbarOverlayColorTheme());

Platform::current()->themeEngine()->paint(canvas, part, state, WebRect(rect),

- 0);

+ &params);

}

ScrollbarPart ScrollbarThemeOverlay::hitTest(