Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 24267018: Suppress redundant seeks to within same usec (Closed)

Created:
7 years, 3 months ago by wolenetz
Modified:
5 years, 6 months ago
Reviewers:
wolenetz
CC:
chromium-reviews, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, jam, wjia+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Suppress redundant seeks to within same usec Don't commit this until this is confirmed, and probably until we add some kind of testing to reveal issue + verify fix. This is a candidate fix CL, but need to first confirm that it is possible for such redundant seeks to occur with Blink + WMPI.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -10 lines) Patch
M content/renderer/media/webmediaplayer_impl.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/media/webmediaplayer_impl.cc View 4 chunks +19 lines, -9 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
wolenetz
7 years, 3 months ago (2013-09-21 02:26:35 UTC) #1
wolenetz
PS1 is broken: https://codereview.chromium.org/24267018/diff/1/content/renderer/media/webmediaplayer_impl.cc File content/renderer/media/webmediaplayer_impl.cc (right): https://codereview.chromium.org/24267018/diff/1/content/renderer/media/webmediaplayer_impl.cc#newcode345 content/renderer/media/webmediaplayer_impl.cc:345: if (seeking_ && new_seek_time == seek_time_) ...
7 years, 2 months ago (2013-10-01 19:51:48 UTC) #2
wolenetz
5 years, 6 months ago (2015-06-09 19:59:02 UTC) #3
On 2013/10/01 19:51:48, wolenetz wrote:
> PS1 is broken:
> 
>
https://codereview.chromium.org/24267018/diff/1/content/renderer/media/webmed...
> File content/renderer/media/webmediaplayer_impl.cc (right):
> 
>
https://codereview.chromium.org/24267018/diff/1/content/renderer/media/webmed...
> content/renderer/media/webmediaplayer_impl.cc:345: if (seeking_ &&
new_seek_time
> == seek_time_) {
> This is incorrect; I'll need to fix this in subsequent PS.
> seek(1)+seek(2)+seek(1) collapses to just seek(1) with a CancelPendingSeek(2)
> that causes kAborted demuxer buffer reads until someone later issues seek(2)
> that issues StartWaitingForSeek(2) or until someone later issues a
non-redundant
> set of seeks such that there eventually is a matching
> CancelPendingSeek+StartWaitingForSeek call.
> 
> See where similar broken optimization was fixed for Chrome for Android in
> https://src.chromium.org/viewvc/chrome?view=rev&revision=226166

Closing this old CL, since there is a current one
(https://codereview.chromium.org/1164343003/) containing a fixed version of this
along with a fix for WMPI::currentTime() racing a previous pipeline::seek() and
returning incorrect time.

Powered by Google App Engine
This is Rietveld 408576698