Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 24267014: low hanging calloc fruit (Closed)

Created:
7 years, 3 months ago by mtklein
Modified:
7 years, 2 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

low hanging calloc fruit BUG= Committed: http://code.google.com/p/skia/source/detail?r=11683

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M src/core/SkBitmap.cpp View 1 chunk +1 line, -2 lines 2 comments Download
M src/core/SkTDynamicHash.h View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
mtklein
7 years, 3 months ago (2013-09-20 19:15:27 UTC) #1
reed1
lgtm Here a biggie, but we may need to tunnel a flag (or new call) ...
7 years, 3 months ago (2013-09-20 19:53:21 UTC) #2
robertphillips
Reverted in r11427 due to Chromium compilation failures: http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/builds/78569/steps/compile/logs/stdio
7 years, 2 months ago (2013-09-22 20:20:34 UTC) #3
mtklein
On 2013/09/22 20:20:34, robertphillips wrote: > Reverted in r11427 due to Chromium compilation failures: > ...
7 years, 2 months ago (2013-10-09 18:15:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/24267014/1
7 years, 2 months ago (2013-10-09 18:15:59 UTC) #5
commit-bot: I haz the power
Change committed as 11683
7 years, 2 months ago (2013-10-09 18:40:04 UTC) #6
scroggo
https://codereview.chromium.org/24267014/diff/1/src/core/SkBitmap.cpp File src/core/SkBitmap.cpp (right): https://codereview.chromium.org/24267014/diff/1/src/core/SkBitmap.cpp#newcode1633 src/core/SkBitmap.cpp:1633: SkBitmap::RLEPixels::RLEPixels(int width, int height) { Does anyone use RLEPixels? ...
7 years, 2 months ago (2013-10-09 18:56:11 UTC) #7
mtklein
7 years, 2 months ago (2013-10-09 19:07:17 UTC) #8
Message was sent while issue was closed.
https://codereview.chromium.org/24267014/diff/1/src/core/SkBitmap.cpp
File src/core/SkBitmap.cpp (right):

https://codereview.chromium.org/24267014/diff/1/src/core/SkBitmap.cpp#newcode...
src/core/SkBitmap.cpp:1633: SkBitmap::RLEPixels::RLEPixels(int width, int
height) {
On 2013/10/09 18:56:11, scroggo wrote:
> Does anyone use RLEPixels? Wasn't it for a config that we removed?

No idea.  Got to admit I did this change entirely pattern-matchy-moron style.

Powered by Google App Engine
This is Rietveld 408576698