src/crankshaft/hydrogen.cc - Issue 2426693002: [ic] Unify CallIC feedback collection and handling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/crankshaft/hydrogen.cc

Issue 2426693002: [ic] Unify CallIC feedback collection and handling. (Closed)

Patch Set: Also simplify BytecodeGraphBuilder::ComputeCallFrequency Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/crankshaft/hydrogen.cc

diff --git a/src/crankshaft/hydrogen.cc b/src/crankshaft/hydrogen.cc

index 87995c02f6539eceb9eb9268d259550f88ddb26b..d84343f7bb5faa0ef8b97f4f0ad0f4e45b975651 100644

--- a/src/crankshaft/hydrogen.cc

+++ b/src/crankshaft/hydrogen.cc

@@ -9605,7 +9605,7 @@ void HOptimizedGraphBuilder::VisitCall(Call* expr) {

syntactic_tail_call_mode, tail_call_mode);

} else {

PushArgumentsFromEnvironment(argument_count);

- if (expr->is_uninitialized() && expr->IsUsingCallFeedbackICSlot()) {

+ if (expr->is_uninitialized()) {

// We've never seen this call before, so let's have Crankshaft learn

// through the type vector.

call = NewCallFunctionViaIC(function, argument_count,

« no previous file with comments | « src/compiler/bytecode-graph-builder.cc ('k') | src/crankshaft/typing.cc » ('j') | no next file with comments »