Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Unified Diff: src/ast/ast.cc

Issue 2426693002: [ic] Unify CallIC feedback collection and handling. (Closed)
Patch Set: Also simplify BytecodeGraphBuilder::ComputeCallFrequency Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ast/ast.h ('k') | src/compiler/bytecode-graph-builder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ast/ast.cc
diff --git a/src/ast/ast.cc b/src/ast/ast.cc
index 34fa095308f60adf2030025ba7f529d60dfa87a4..b52fb957e8b80f53250c43df6b59b5fbd85e89e6 100644
--- a/src/ast/ast.cc
+++ b/src/ast/ast.cc
@@ -889,25 +889,9 @@ bool Expression::IsMonomorphic() const {
}
}
-bool Call::IsUsingCallFeedbackICSlot() const {
- return GetCallType() != POSSIBLY_EVAL_CALL;
-}
-
-bool Call::IsUsingCallFeedbackSlot() const {
- // SuperConstructorCall uses a CallConstructStub, which wants
- // a Slot, in addition to any IC slots requested elsewhere.
- return GetCallType() == SUPER_CALL;
-}
-
-
void Call::AssignFeedbackVectorSlots(Isolate* isolate, FeedbackVectorSpec* spec,
FeedbackVectorSlotCache* cache) {
- if (IsUsingCallFeedbackICSlot()) {
- ic_slot_ = spec->AddCallICSlot();
- }
- if (IsUsingCallFeedbackSlot()) {
- stub_slot_ = spec->AddGeneralSlot();
- }
+ ic_slot_ = spec->AddCallICSlot();
}
Call::CallType Call::GetCallType() const {
« no previous file with comments | « src/ast/ast.h ('k') | src/compiler/bytecode-graph-builder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698