Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Side by Side Diff: src/full-codegen/arm/full-codegen-arm.cc

Issue 2426693002: [ic] Unify CallIC feedback collection and handling. (Closed)
Patch Set: Also simplify BytecodeGraphBuilder::ComputeCallFrequency Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/typing.cc ('k') | src/full-codegen/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM 5 #if V8_TARGET_ARCH_ARM
6 6
7 #include "src/full-codegen/full-codegen.h" 7 #include "src/full-codegen/full-codegen.h"
8 #include "src/ast/compile-time-value.h" 8 #include "src/ast/compile-time-value.h"
9 #include "src/ast/scopes.h" 9 #include "src/ast/scopes.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 2473 matching lines...) Expand 10 before | Expand all | Expand 10 after
2484 __ push(r1); 2484 __ push(r1);
2485 EmitResolvePossiblyDirectEval(expr); 2485 EmitResolvePossiblyDirectEval(expr);
2486 2486
2487 // Touch up the stack with the resolved function. 2487 // Touch up the stack with the resolved function.
2488 __ str(r0, MemOperand(sp, (arg_count + 1) * kPointerSize)); 2488 __ str(r0, MemOperand(sp, (arg_count + 1) * kPointerSize));
2489 2489
2490 PrepareForBailoutForId(expr->EvalId(), BailoutState::NO_REGISTERS); 2490 PrepareForBailoutForId(expr->EvalId(), BailoutState::NO_REGISTERS);
2491 2491
2492 // Record source position for debugger. 2492 // Record source position for debugger.
2493 SetCallPosition(expr); 2493 SetCallPosition(expr);
2494 Handle<Code> code = CodeFactory::CallIC(isolate(), ConvertReceiverMode::kAny,
2495 expr->tail_call_mode())
2496 .code();
2497 __ mov(r3, Operand(SmiFromSlot(expr->CallFeedbackICSlot())));
2494 __ ldr(r1, MemOperand(sp, (arg_count + 1) * kPointerSize)); 2498 __ ldr(r1, MemOperand(sp, (arg_count + 1) * kPointerSize));
2495 __ mov(r0, Operand(arg_count)); 2499 __ mov(r0, Operand(arg_count));
2496 __ Call(isolate()->builtins()->Call(ConvertReceiverMode::kAny, 2500 __ Call(code, RelocInfo::CODE_TARGET);
2497 expr->tail_call_mode()),
2498 RelocInfo::CODE_TARGET);
2499 OperandStackDepthDecrement(arg_count + 1); 2501 OperandStackDepthDecrement(arg_count + 1);
2500 RecordJSReturnSite(expr); 2502 RecordJSReturnSite(expr);
2501 RestoreContext(); 2503 RestoreContext();
2502 context()->DropAndPlug(1, r0); 2504 context()->DropAndPlug(1, r0);
2503 } 2505 }
2504 2506
2505 2507
2506 void FullCodeGenerator::VisitCallNew(CallNew* expr) { 2508 void FullCodeGenerator::VisitCallNew(CallNew* expr) {
2507 Comment cmnt(masm_, "[ CallNew"); 2509 Comment cmnt(masm_, "[ CallNew");
2508 // According to ECMA-262, section 11.2.2, page 44, the function 2510 // According to ECMA-262, section 11.2.2, page 44, the function
(...skipping 1217 matching lines...) Expand 10 before | Expand all | Expand 10 after
3726 DCHECK(interrupt_address == 3728 DCHECK(interrupt_address ==
3727 isolate->builtins()->OnStackReplacement()->entry()); 3729 isolate->builtins()->OnStackReplacement()->entry());
3728 return ON_STACK_REPLACEMENT; 3730 return ON_STACK_REPLACEMENT;
3729 } 3731 }
3730 3732
3731 3733
3732 } // namespace internal 3734 } // namespace internal
3733 } // namespace v8 3735 } // namespace v8
3734 3736
3735 #endif // V8_TARGET_ARCH_ARM 3737 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/crankshaft/typing.cc ('k') | src/full-codegen/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698