Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2426663002: 📰 Add default empty state strings for remote sections (Closed)

Created:
4 years, 2 months ago by dgn
Modified:
4 years, 2 months ago
Reviewers:
Marc Treib
CC:
chromium-reviews, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP Client] Add default empty state strings for remote sections Preview: https://goo.gl/photos/aK3GPFL5Z7MSzcwn8 BUG=656008 Committed: https://crrev.com/b48353878e2fcf4d3223daed5d5c13e5bbcf2e04 Cr-Commit-Position: refs/heads/master@{#425932}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsCategoryInfo.java View 1 chunk +2 lines, -3 lines 0 comments Download
M components/ntp_snippets_strings.grdp View 1 chunk +3 lines, -0 lines 2 comments Download

Messages

Total messages: 18 (10 generated)
dgn
PTAL
4 years, 2 months ago (2016-10-17 16:31:21 UTC) #8
dgn
PTAL
4 years, 2 months ago (2016-10-17 16:31:22 UTC) #9
Marc Treib
https://codereview.chromium.org/2426663002/diff/1/components/ntp_snippets_strings.grdp File components/ntp_snippets_strings.grdp (right): https://codereview.chromium.org/2426663002/diff/1/components/ntp_snippets_strings.grdp#newcode15 components/ntp_snippets_strings.grdp:15: Your suggestions appear here The other two "empty" strings ...
4 years, 2 months ago (2016-10-18 08:00:08 UTC) #10
dgn
https://codereview.chromium.org/2426663002/diff/1/components/ntp_snippets_strings.grdp File components/ntp_snippets_strings.grdp (right): https://codereview.chromium.org/2426663002/diff/1/components/ntp_snippets_strings.grdp#newcode15 components/ntp_snippets_strings.grdp:15: Your suggestions appear here On 2016/10/18 08:00:08, Marc Treib ...
4 years, 2 months ago (2016-10-18 09:05:44 UTC) #11
Marc Treib
Ah I see - didn't know we were updating the other strings too. LGTM then! ...
4 years, 2 months ago (2016-10-18 09:09:21 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2426663002/1
4 years, 2 months ago (2016-10-18 09:19:38 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-18 09:24:33 UTC) #16
commit-bot: I haz the power
4 years, 2 months ago (2016-10-18 09:26:14 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b48353878e2fcf4d3223daed5d5c13e5bbcf2e04
Cr-Commit-Position: refs/heads/master@{#425932}

Powered by Google App Engine
This is Rietveld 408576698