Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(786)

Unified Diff: third_party/WebKit/public/platform/modules/mediasession/media_session.mojom

Issue 2426653002: Adding mojo MediaSessionClient to support media controls (Closed)
Patch Set: Still rough, depends on "blink media controls" CL Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/platform/modules/mediasession/media_session.mojom
diff --git a/third_party/WebKit/public/platform/modules/mediasession/media_session.mojom b/third_party/WebKit/public/platform/modules/mediasession/media_session.mojom
index dae65f6e339dbc465103e023d64599ffba08892a..d416c4fb026619d81e4be4bbc150aa42d8b5f276 100644
--- a/third_party/WebKit/public/platform/modules/mediasession/media_session.mojom
+++ b/third_party/WebKit/public/platform/modules/mediasession/media_session.mojom
@@ -25,6 +25,16 @@ struct MediaMetadata {
array<MediaImage> artwork;
};
+interface MediaSessionClient {
+ DidReceivedAction(string action);
whywhat 2016/10/17 15:38:43 Could you change action from string to enum?
Zhiqiang Zhang (Slow) 2016/10/17 21:17:39 Done. However it seems mapping values enum (or int
+};
+
interface MediaSessionService {
+ // MediaSessionClient interface is to used to notify Blink MediaSession of
+ // media control actions.
+ SetClient(MediaSessionClient client);
+
SetMetadata(MediaMetadata? metadata);
+
+ DidSetEventHandlerForAction(string action, bool is_set);
whywhat 2016/10/17 15:38:43 Could you change is_set to two methods? Maybe the
Zhiqiang Zhang (Slow) 2016/10/17 21:17:39 Done.
};

Powered by Google App Engine
This is Rietveld 408576698