third_party/WebKit/LayoutTests/media/mediasession/mojo/media-control-unset-handler-notifies-service.html - Issue 2426653002: Adding mojo MediaSessionClient to support media controls

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/mediasession/mojo/media-control-unset-handler-notifies-service.html

Issue 2426653002: Adding mojo MediaSessionClient to support media controls (Closed)

Patch Set: Addressed haraken's comments Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/media/mediasession/mojo/media-control-set-handler-notifies-service.html ('K') | « third_party/WebKit/LayoutTests/media/mediasession/mojo/media-control-set-handler-notifies-service.html ('k') | third_party/WebKit/LayoutTests/media/mediasession/mojo/resources/mediasessionservice-mock.js » ('j') | third_party/WebKit/Source/modules/mediasession/MediaSession.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <title>MediaSession Mojo Test</title>

	3 <script src="../../../resources/testharness.js"></script>

	4 <script src="../../../resources/testharnessreport.js"></script>

	5 <script src="../../../resources/mojo-helpers.js"></script>

	6 <script src="resources/mediasessionservice-mock.js"></script>

	7 <script src="resources/utils.js"></script>

	8 <script>

	9

	10 var expectations = [

	11 [ 0, true ],

	12 [ 1, true ],

	13 [ 2, true ],

	14 [ 3, true ],

	15 [ 4, true ],

	16 [ 5, true ],

	17 [ 6, true ],

	18 [ 0, false ],

	19 [ 1, false ],

	20 [ 2, false ],

	21 [ 3, false ],

	22 [ 4, false ],

	23 [ 5, false ],

	24 [ 6, false ],

	25 ];

	26

	27 var nextExpectation = 0;

	28

	29 async_test(function(t) {

	30 mediaSessionServiceMock.then(m => {

	31 m.setEnableDisableActionCallback(t.step_func(function(action, isEnabled) {

	32 var expectedAction = expectations[nextExpectation][0];

	33 var expectedIsEnabled = expectations[nextExpectation][1];

	34 assert_equals(expectedAction, action);

	35 assert_equals(expectedIsEnabled, isEnabled);

	36 if (++nextExpectation >= expectations.length)

	37 t.done();

	38 }));

	39

	40 // Unknown function should not be propagated.

	41 window.navigator.mediaSession.onresize = _ => {};

	42 // MediaSession events should be propagated.

	43 window.navigator.mediaSession.onplay = _ => {};

	44 window.navigator.mediaSession.onpause = _ => {};

	45 window.navigator.mediaSession.onplaypause = _ => {};

	46 window.navigator.mediaSession.onprevioustrack = _ => {};

	47 window.navigator.mediaSession.onnexttrack = _ => {};

	48 window.navigator.mediaSession.onseekforward = _ => {};

	49 window.navigator.mediaSession.onseekbackward = _ => {};

	50

	51 // Unknown function should not be propagated.

	52 window.navigator.mediaSession.onresize = null;

	53 // MediaSession events should be propagated.

	54 window.navigator.mediaSession.onplay = null;

	55 window.navigator.mediaSession.onpause = null;

	56 window.navigator.mediaSession.onplaypause = null;

	57 window.navigator.mediaSession.onprevioustrack = null;

	58 window.navigator.mediaSession.onnexttrack = null;

	59 window.navigator.mediaSession.onseekforward = null;

	60 window.navigator.mediaSession.onseekbackward = null;

	61 });

	62 }, "test that setting event handler notifies the mojo service");
	whywhat 2016/10/18 21:02:57 I think you should only leave this one. I think you should only leave this one. Zhiqiang Zhang (Slow) 2016/10/19 12:52:06 Merged all three into one. Show quoted text On 2016/10/18 21:02:57, whywhat wrote: > I think you should only leave this one. Merged all three into one.
	63

	64 </script>

OLD	NEW