net/quic/core/quic_crypto_stream.cc - Issue 2426603003: refactor only: Move around flag protection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/core/quic_crypto_stream.cc

Issue 2426603003: refactor only: Move around flag protection. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/quic/core/quic_crypto_stream.cc

diff --git a/net/quic/core/quic_crypto_stream.cc b/net/quic/core/quic_crypto_stream.cc

index be7271c519f797009d8045845ba920c8ca22ecd3..fcb5397ce4dff73b42f78e8a29bf4366d6c320a1 100644

--- a/net/quic/core/quic_crypto_stream.cc

+++ b/net/quic/core/quic_crypto_stream.cc

@@ -69,7 +69,8 @@ void QuicCryptoStream::OnDataAvailable() {

return;

}

sequencer()->MarkConsumed(iov.iov_len);

- if (handshake_confirmed_ && crypto_framer_.InputBytesRemaining() == 0) {

+ if (handshake_confirmed_ && crypto_framer_.InputBytesRemaining() == 0 &&

+ FLAGS_quic_release_crypto_stream_buffer) {

// If the handshake is complete and the current message has been fully

// processed then no more handshake messages are likely to arrive soon

// so release the memory in the stream sequencer.

« no previous file with comments | « no previous file | net/quic/core/quic_stream_sequencer.cc » ('j') | no next file with comments »