Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1114)

Issue 24266007: MIPS: Fixed a bug in CopyBytes() and new test cases for MIPS macro assembler. (Closed)

Created:
7 years, 3 months ago by kilvadyb
Modified:
7 years, 2 months ago
CC:
v8-dev
Base URL:
https://github.com/v8/v8.git@gbl
Visibility:
Public.

Description

MIPS: Fixed a bug in CopyBytes() and new test cases for MIPS macro assembler. Port r16873 (c2880bc) BUG= TEST=cctest/test-macro-assembler-mips

Patch Set 1 #

Total comments: 4

Patch Set 2 : fix comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -21 lines) Patch
M src/mips/macro-assembler-mips.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A + test/cctest/test-macro-assembler-mips.cc View 1 4 chunks +17 lines, -17 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kilvadyb
7 years, 3 months ago (2013-09-23 11:55:51 UTC) #1
Bangfu
please update comments https://codereview.chromium.org/24266007/diff/1/test/cctest/test-macro-assembler-mips.cc File test/cctest/test-macro-assembler-mips.cc (left): https://codereview.chromium.org/24266007/diff/1/test/cctest/test-macro-assembler-mips.cc#oldcode76 test/cctest/test-macro-assembler-mips.cc:76: // Storage for R0 and R1. ...
7 years, 3 months ago (2013-09-23 12:59:07 UTC) #2
kilvadyb
https://codereview.chromium.org/24266007/diff/1/test/cctest/test-macro-assembler-mips.cc File test/cctest/test-macro-assembler-mips.cc (left): https://codereview.chromium.org/24266007/diff/1/test/cctest/test-macro-assembler-mips.cc#oldcode76 test/cctest/test-macro-assembler-mips.cc:76: // Storage for R0 and R1. On 2013/09/23 12:59:07, ...
7 years, 3 months ago (2013-09-23 15:30:16 UTC) #3
Paul Lind
lgtm
7 years, 3 months ago (2013-09-23 16:48:21 UTC) #4
palfia
7 years, 3 months ago (2013-09-23 19:40:19 UTC) #5
Committed as r16904.

Powered by Google App Engine
This is Rietveld 408576698