Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issue 2426583003: Improve error messages and add many corrections (Closed)

Created:
4 years, 2 months ago by Brian Wilkerson
Modified:
4 years, 2 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1488 lines, -842 lines) Patch
M pkg/analyzer/lib/error/error.dart View 4 chunks +48 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/dart/error/syntactic_errors.dart View 8 chunks +534 lines, -244 lines 0 comments Download
M pkg/analyzer/lib/src/error/codes.dart View 277 chunks +861 lines, -559 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error_verifier.dart View 5 chunks +36 lines, -8 lines 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 3 chunks +5 lines, -3 lines 0 comments Download
M pkg/analyzer/test/generated/compile_time_error_code_test.dart View 2 chunks +3 lines, -11 lines 0 comments Download
M pkg/analyzer/test/generated/hint_code_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analyzer/test/generated/static_type_warning_code_test.dart View 1 chunk +0 lines, -8 lines 0 comments Download
M pkg/analyzer/test/src/task/options_test.dart View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
Updated the wording of messages to match the criteria Florian wrote out (primarily, less formal ...
4 years, 2 months ago (2016-10-17 16:19:52 UTC) #2
scheglov
LGTM
4 years, 2 months ago (2016-10-17 16:50:52 UTC) #3
Brian Wilkerson
4 years, 2 months ago (2016-10-17 17:40:47 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
724ac40b8dbf3aaad74321f0abf8584ed28c611d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698