Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2426553002: Add mb config for linux_chromium_headless_rel (Closed)

Created:
4 years, 2 months ago by perezju
Modified:
4 years, 2 months ago
Reviewers:
Dirk Pranke, Sami
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add mb config for linux_chromium_headless_rel BUG=632008 Committed: https://crrev.com/fb2b97208a79b561b514870669269b6ddbc93d77 Cr-Commit-Position: refs/heads/master@{#425928}

Patch Set 1 #

Total comments: 1

Patch Set 2 : rename .gn files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M build/args/bots/tryserver.chromium.linux/headless_linux_dbg_trybot.gn View 1 1 chunk +0 lines, -4 lines 0 comments Download
A + build/args/bots/tryserver.chromium.linux/linux_chromium_headless_dbg.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
A + build/args/bots/tryserver.chromium.linux/linux_chromium_headless_rel.gn View 1 1 chunk +2 lines, -1 line 0 comments Download
M tools/mb/mb_config.pyl View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
perezju
The plan is to land: 1. This chromium CL to add the new config 2. ...
4 years, 2 months ago (2016-10-17 10:40:50 UTC) #2
Dirk Pranke
lgtm w/ rename of the files in //build/args if that's okay. https://codereview.chromium.org/2426553002/diff/1/build/args/bots/tryserver.chromium.linux/headless_linux_rel_trybot.gn File build/args/bots/tryserver.chromium.linux/headless_linux_rel_trybot.gn (right): ...
4 years, 2 months ago (2016-10-17 17:12:07 UTC) #3
perezju
Renamed .gn files to match the builder name. Thanks!
4 years, 2 months ago (2016-10-18 08:14:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2426553002/20001
4 years, 2 months ago (2016-10-18 08:15:01 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-18 09:13:07 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-18 09:14:41 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fb2b97208a79b561b514870669269b6ddbc93d77
Cr-Commit-Position: refs/heads/master@{#425928}

Powered by Google App Engine
This is Rietveld 408576698