Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Unified Diff: third_party/WebKit/Source/web/ContextMenuClientImpl.cpp

Issue 2426523002: Audit use of updateStyleAndLayoutIgnorePendingStylesheets in EditingStyle::styleAtSelectionStart (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/ContextMenuClientImpl.cpp
diff --git a/third_party/WebKit/Source/web/ContextMenuClientImpl.cpp b/third_party/WebKit/Source/web/ContextMenuClientImpl.cpp
index efa6a0b9ef74702c5069835da12a72774c51ad65..01ccd42ceb386af444aa2288318f3dd660d0561b 100644
--- a/third_party/WebKit/Source/web/ContextMenuClientImpl.cpp
+++ b/third_party/WebKit/Source/web/ContextMenuClientImpl.cpp
@@ -347,6 +347,11 @@ bool ContextMenuClientImpl::showContextMenu(const ContextMenu* defaultMenu,
}
}
+ // TODO(editing-dev): The use of updateStyleAndLayoutIgnorePendingStylesheets
+ // needs to be audited. See http://crbug.com/590369 for more details.
+ // Plain text extraction requires clean layout.
+ selectedFrame->document()->updateStyleAndLayoutIgnorePendingStylesheets();
+
if (selectedFrame->editor().selectionHasStyle(CSSPropertyDirection, "ltr") !=
FalseTriState)
data.writingDirectionLeftToRight |=
« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698