content/renderer/render_view_impl.cc - Issue 2426503002: Make printing work better with OOPIF.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_impl.cc

Issue 2426503002: Make printing work better with OOPIF. (Closed)

Patch Set: Check GetFrameToPrint and remove another TODO Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/render_view_impl.cc

diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc

index 670a2238d453022516a88fc7af5ee98af24c1fd5..d64113c8b42ab0e1b7b8dd675912fae66d44cee7 100644

--- a/content/renderer/render_view_impl.cc

+++ b/content/renderer/render_view_impl.cc

@@ -1635,8 +1635,8 @@ void RenderViewImpl::printPage(WebLocalFrame* frame) {

UMA_HISTOGRAM_BOOLEAN("PrintPreview.OutOfProcessSubframe",

frame->top()->isWebRemoteFrame());

- for (auto& observer : observers_)

- observer.PrintPage(frame, input_handler().handling_input_event());

+ RenderFrameImpl::FromWebFrame(frame)->ScriptedPrint(

+ input_handler().handling_input_event());

}

bool RenderViewImpl::enumerateChosenDirectory(