Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10564)

Unified Diff: chrome/renderer/chrome_content_renderer_client.cc

Issue 2426503002: Make printing work better with OOPIF. (Closed)
Patch Set: Check GetFrameToPrint and remove another TODO Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/chrome_content_renderer_client.cc
diff --git a/chrome/renderer/chrome_content_renderer_client.cc b/chrome/renderer/chrome_content_renderer_client.cc
index b9c6c05a897751146857111737fcd5362b1a86ac..177548bf2b9dc2675ed569d36def630adf82d9e1 100644
--- a/chrome/renderer/chrome_content_renderer_client.cc
+++ b/chrome/renderer/chrome_content_renderer_client.cc
@@ -472,6 +472,11 @@ void ChromeContentRendererClient::RenderFrameCreated(
safe_browsing::ThreatDOMDetails::Create(render_frame);
#endif
+#if BUILDFLAG(ENABLE_PRINTING)
+ new printing::PrintWebViewHelper(
+ render_frame, base::MakeUnique<ChromePrintWebViewHelperDelegate>());
+#endif
+
new NetErrorHelper(render_frame);
if (render_frame->IsMainFrame()) {
@@ -520,11 +525,7 @@ void ChromeContentRendererClient::RenderViewCreated(
#if defined(ENABLE_EXTENSIONS)
ChromeExtensionsRendererClient::GetInstance()->RenderViewCreated(render_view);
#endif
-#if BUILDFLAG(ENABLE_PRINTING)
- new printing::PrintWebViewHelper(
- render_view, std::unique_ptr<printing::PrintWebViewHelper::Delegate>(
- new ChromePrintWebViewHelperDelegate()));
-#endif
+
#if defined(ENABLE_SPELLCHECK)
new SpellCheckProvider(render_view, spellcheck_.get());
#endif

Powered by Google App Engine
This is Rietveld 408576698