Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3053)

Unified Diff: android_webview/renderer/aw_content_renderer_client.cc

Issue 2426503002: Make printing work better with OOPIF. (Closed)
Patch Set: rebase, many cleanups have been committed Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/renderer/aw_content_renderer_client.cc
diff --git a/android_webview/renderer/aw_content_renderer_client.cc b/android_webview/renderer/aw_content_renderer_client.cc
index 20754a7156cdf43ad711b98db8ba4daffa74cafe..c05fa508ddf9833d997a5f1cd7191469cb224de8 100644
--- a/android_webview/renderer/aw_content_renderer_client.cc
+++ b/android_webview/renderer/aw_content_renderer_client.cc
@@ -148,6 +148,8 @@ void AwContentRendererClient::RenderFrameCreated(
content::RenderFrame* render_frame) {
new AwContentSettingsClient(render_frame);
new PrintRenderFrameObserver(render_frame);
+ new printing::PrintWebViewHelper(
+ render_frame, base::MakeUnique<AwPrintWebViewHelperDelegate>());
new AwRenderFrameExt(render_frame);
// TODO(jam): when the frame tree moves into content and parent() works at
@@ -172,10 +174,6 @@ void AwContentRendererClient::RenderViewCreated(
content::RenderView* render_view) {
AwRenderViewExt::RenderViewCreated(render_view);
- new printing::PrintWebViewHelper(
- render_view, std::unique_ptr<printing::PrintWebViewHelper::Delegate>(
- new AwPrintWebViewHelperDelegate()));
-
#if defined(ENABLE_SPELLCHECK)
new SpellCheckProvider(render_view, spellcheck_.get());
#endif

Powered by Google App Engine
This is Rietveld 408576698