Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(852)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/browser_commands.cc

Issue 2426503002: Make printing work better with OOPIF. (Closed)
Patch Set: Fix build, nits Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/printing/print_view_manager_common.cc ('K') | « chrome/browser/printing/printing_message_filter.cc ('k') | chrome/browser/ui/cocoa/applescript/tab_applescript.mm » ('j') | chrome/renderer/printing/chrome_print_web_view_helper_delegate.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser_commands.cc
diff --git a/chrome/browser/ui/browser_commands.cc b/chrome/browser/ui/browser_commands.cc
index 4b328bcd344b0519969b1833423c8ac61d192a61..8781e35f5939100afc68b42c8cb56deb9fa53c87 100644
--- a/chrome/browser/ui/browser_commands.cc
+++ b/chrome/browser/ui/browser_commands.cc
@@ -874,10 +874,10 @@ void ShowWebsiteSettings(
void Print(Browser* browser) {
#if defined(ENABLE_PRINTING)
- printing::StartPrint(
- browser->tab_strip_model()->GetActiveWebContents(),
- browser->profile()->GetPrefs()->GetBoolean(prefs::kPrintPreviewDisabled),
- false);
+ auto* web_contents = browser->tab_strip_model()->GetActiveWebContents();
+ printing::StartPrint(web_contents, browser->profile()->GetPrefs()->GetBoolean(
+ prefs::kPrintPreviewDisabled),
+ false /* has_selection? */);
#endif // defined(ENABLE_PRINTING)
}
« chrome/browser/printing/print_view_manager_common.cc ('K') | « chrome/browser/printing/printing_message_filter.cc ('k') | chrome/browser/ui/cocoa/applescript/tab_applescript.mm » ('j') | chrome/renderer/printing/chrome_print_web_view_helper_delegate.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698