Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1513)

Unified Diff: android_webview/renderer/print_render_frame_observer.cc

Issue 2426503002: Make printing work better with OOPIF. (Closed)
Patch Set: Fix build, nits Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/renderer/print_render_frame_observer.cc
diff --git a/android_webview/renderer/print_render_frame_observer.cc b/android_webview/renderer/print_render_frame_observer.cc
index 2542d7640bb5a7a0c8dec3868b8a11c88fc1b013..d8d9c3137efe0f55577674199f9fd22c3f8c60ad 100644
--- a/android_webview/renderer/print_render_frame_observer.cc
+++ b/android_webview/renderer/print_render_frame_observer.cc
@@ -33,7 +33,7 @@ bool PrintRenderFrameObserver::OnMessageReceived(
void PrintRenderFrameObserver::OnPrintNodeUnderContextMenu() {
printing::PrintWebViewHelper* helper =
- printing::PrintWebViewHelper::Get(render_frame()->GetRenderView());
+ printing::PrintWebViewHelper::Get(render_frame());
if (helper)
helper->PrintNode(render_frame()->GetWebFrame()->contextMenuNode());
nasko 2016/11/02 04:50:37 I hope we send the context menu to the right rende
Lei Zhang 2016/11/08 11:13:22 What's making your spidey sense tingle? I made the
nasko 2016/11/08 22:18:35 Looking back at it, I don't know : (. This is rend
}

Powered by Google App Engine
This is Rietveld 408576698