Make printing work better with OOPIF.

chrome/renderer/printing/chrome_print_web_view_helper_delegate.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/printing/chrome_print_web_view_helper_delegate.h"
 
 #include <vector>
 
 #include "base/command_line.h"
 #include "base/strings/string_util.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/render_messages.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/renderer/prerender/prerender_helper.h"
 #include "content/public/renderer/render_frame.h"
 #include "content/public/renderer/render_view.h"
 #include "ipc/ipc_message.h"
 #include "third_party/WebKit/public/web/WebDocument.h"
 #include "third_party/WebKit/public/web/WebElement.h"
 #include "third_party/WebKit/public/web/WebLocalFrame.h"
 
 #if defined(ENABLE_EXTENSIONS)
 #include "chrome/common/extensions/extension_constants.h"
 #include "extensions/common/constants.h"
 #include "extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.h"
 #endif  // defined(ENABLE_EXTENSIONS)
 
-ChromePrintWebViewHelperDelegate::~ChromePrintWebViewHelperDelegate(){
-}
+ChromePrintWebViewHelperDelegate::~ChromePrintWebViewHelperDelegate() {}
 
 bool ChromePrintWebViewHelperDelegate::CancelPrerender(
-    content::RenderView* render_view, int routing_id) {
-  if (!render_view || !prerender::PrerenderHelper::IsPrerendering(
-      render_view->GetMainRenderFrame()))
+    content::RenderFrame* render_frame) {
+  if (!prerender::PrerenderHelper::IsPrerendering(render_frame))
     return false;
 
-  return render_view->Send(
-      new ChromeViewHostMsg_CancelPrerenderForPrinting(routing_id));
+  auto* render_view = render_frame->GetRenderView();
+  return render_view->Send(new ChromeViewHostMsg_CancelPrerenderForPrinting(
+      render_view->GetRoutingID()));

[nasko, 2016/11/02 04:50:37]

Why is this still using the RenderView routing id? Shouldn't it route through
the frame?

[Lei Zhang, 2016/11/08 11:13:22]

PrerenderContents hasn't changed in this CL, so we still need to interact with
it like before.

[nasko, 2016/11/08 22:18:35]

Acknowledged.

 }
 
 // Return the PDF object element if |frame| is the out of process PDF extension.
 blink::WebElement ChromePrintWebViewHelperDelegate::GetPdfElement(
         blink::WebLocalFrame* frame) {
 #if defined(ENABLE_EXTENSIONS)
   GURL url = frame->document().url();
   bool inside_print_preview = url.GetOrigin() == chrome::kChromeUIPrintURL;
   bool inside_pdf_extension = url.SchemeIs(extensions::kExtensionScheme) &&
                               url.host() == extension_misc::kPdfExtensionId;
@@ skipping 30 matching lines @@
     // PDF plugin document correctly print the PDF. See
     // https://crbug.com/448720.
     base::DictionaryValue message;
     message.SetString("type", "print");
     mime_handlers.front()->PostMessageFromValue(message);
     return true;
   }
 #endif  // defined(ENABLE_EXTENSIONS)
   return false;
 }