Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1864)

Issue 24265002: bulk replace v8::Isolate::GetCurrent in tests (Closed)

Created:
7 years, 3 months ago by dcarney
Modified:
7 years, 3 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

bulk replace v8::Isolate::GetCurrent in tests R=svenpanne@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=16813

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+378 lines, -378 lines) Patch
M test/cctest/test-accessors.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M test/cctest/test-alloc.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/test-api.cc View 251 chunks +288 lines, -288 lines 0 comments Download
M test/cctest/test-assembler-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-assembler-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-debug.cc View 14 chunks +15 lines, -15 lines 0 comments Download
M test/cctest/test-declarative-accessors.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-hashing.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-heap.cc View 9 chunks +11 lines, -11 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/test-log.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M test/cctest/test-parsing.cc View 6 chunks +9 lines, -9 lines 0 comments Download
M test/cctest/test-platform.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-profile-generator.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-random.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-regexp.cc View 7 chunks +8 lines, -8 lines 0 comments Download
M test/cctest/test-serialize.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M test/cctest/test-strings.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-thread-termination.cc View 8 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dcarney
7 years, 3 months ago (2013-09-19 08:50:38 UTC) #1
Sven Panne
LGTM (rubberstamped)
7 years, 3 months ago (2013-09-19 08:52:41 UTC) #2
dcarney
7 years, 3 months ago (2013-09-19 08:55:20 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16813 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698