Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2426493003: [LayoutNG] Capitalize functions in ng_length_utils.h (Closed)

Created:
4 years, 2 months ago by ikilpatrick
Modified:
4 years, 2 months ago
Reviewers:
cbiesinger, eae
CC:
chromium-reviews, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Capitalize functions in ng_length_utils.h BUG=635619 Committed: https://crrev.com/9c99bf64a25d97e714fbbeba69ed0384e98eb1ed Cr-Commit-Position: refs/heads/master@{#425872}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -94 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_box.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_length_utils.h View 2 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc View 8 chunks +25 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc View 6 chunks +54 lines, -54 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
ikilpatrick
4 years, 2 months ago (2016-10-17 21:24:53 UTC) #4
cbiesinger
Awesome, thank you! lgtm
4 years, 2 months ago (2016-10-17 21:26:25 UTC) #6
eae
LGTM Thanks, we should see if we can get clanfg-format (or check-webkit-style) to enforce this.
4 years, 2 months ago (2016-10-17 21:37:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2426493003/1
4 years, 2 months ago (2016-10-17 21:39:09 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/161972)
4 years, 2 months ago (2016-10-18 01:21:18 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2426493003/1
4 years, 2 months ago (2016-10-18 01:23:40 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-18 02:51:22 UTC) #16
commit-bot: I haz the power
4 years, 2 months ago (2016-10-18 02:54:58 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9c99bf64a25d97e714fbbeba69ed0384e98eb1ed
Cr-Commit-Position: refs/heads/master@{#425872}

Powered by Google App Engine
This is Rietveld 408576698