|
|
Chromium Code Reviews
DescriptionAdd DISALLOW_COPY_AND_ASSIGN in web_data_consumer_handle_impl.h.
When I tried to include web_data_consumer_handle_impl.h from
service_worker_context_client.cc in https://codereview.chromium.org/2416843002/,
I saw the following compile error on windows.
To avoid this problem, this CL adds DISALLOW_COPY_AND_ASSIGN in web_data_consumer_handle_impl.h.
----
e:\b\c\b\win\src\base\memory\ref_counted.h(402):
error C2027: use of undefined type 'content::WebDataConsumerHandleImpl::Context'
e:\b\c\b\win\src\content\child\web_data_consumer_handle_impl.h(22):
note: see declaration of 'content::WebDataConsumerHandleImpl::Context'
e:\b\c\b\win\src\base\memory\ref_counted.h(401):
note: while compiling class template member function
'void scoped_refptr<content::WebDataConsumerHandleImpl::Context>::AddRef(T *)'
with
[
T=content::WebDataConsumerHandleImpl::Context
]
e:\b\c\b\win\src\base\memory\ref_counted.h(285):
note: see reference to function template instantiation
'void scoped_refptr<content::WebDataConsumerHandleImpl::Context>::AddRef(T *)'
being compiled
with
[
T=content::WebDataConsumerHandleImpl::Context
]
e:\b\c\b\win\src\content\child\web_data_consumer_handle_impl.h(43):
note: see reference to class template instantiation
'scoped_refptr<content::WebDataConsumerHandleImpl::Context>' being compiled
e:\b\c\b\win\src\base\memory\ref_counted.h(402):
error C2227: left of '->AddRef' must point to class/struct/union/generic type
---
https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/277294/steps/compile%20%28with%20patch%29/logs/stdio
BUG=649558
Committed: https://crrev.com/77e1af6093d3634a5367cfc090e531e5a72cd0f4
Cr-Commit-Position: refs/heads/master@{#425989}
Patch Set 1 #Patch Set 2 : unset-upstream #Patch Set 3 : Add DISALLOW_COPY_AND_ASSIGN in web_data_consumer_handle_impl.h #
Total comments: 2
Patch Set 4 : incorporated yhirano's comment #
Total comments: 4
Patch Set 5 : add blank lines #Messages
Total messages: 39 (27 generated)
The CQ bit was checked by horo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by horo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Move the definition of ScopedDataPipeConsumerHandle::Context to the header file. BUG= ========== to ========== Move the definition of ScopedDataPipeConsumerHandle::Context to the header file. When I added #include "content/child/web_data_consumer_handle_impl.h" to service_worker_context_client.cc in https://codereview.chromium.org/2416843002/, I saw the following error. I think this is a bug of a compiler (VS). To fix this problem, this CL moves the definition of ScopedDataPipeConsumerHandle::Context to the header file. ---- e:\b\c\b\win\src\base\memory\ref_counted.h(402): error C2027: use of undefined type 'content::WebDataConsumerHandleImpl::Context' e:\b\c\b\win\src\content\child\web_data_consumer_handle_impl.h(22): note: see declaration of 'content::WebDataConsumerHandleImpl::Context' e:\b\c\b\win\src\base\memory\ref_counted.h(401): note: while compiling class template member function 'void scoped_refptr<content::WebDataConsumerHandleImpl::Context>::AddRef(T *)' with [ T=content::WebDataConsumerHandleImpl::Context ] e:\b\c\b\win\src\base\memory\ref_counted.h(285): note: see reference to function template instantiation 'void scoped_refptr<content::WebDataConsumerHandleImpl::Context>::AddRef(T *)' being compiled with [ T=content::WebDataConsumerHandleImpl::Context ] e:\b\c\b\win\src\content\child\web_data_consumer_handle_impl.h(43): note: see reference to class template instantiation 'scoped_refptr<content::WebDataConsumerHandleImpl::Context>' being compiled e:\b\c\b\win\src\base\memory\ref_counted.h(402): error C2227: left of '->AddRef' must point to class/struct/union/generic type --- https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_com... BUG=649558 ==========
Description was changed from ========== Move the definition of ScopedDataPipeConsumerHandle::Context to the header file. When I added #include "content/child/web_data_consumer_handle_impl.h" to service_worker_context_client.cc in https://codereview.chromium.org/2416843002/, I saw the following error. I think this is a bug of a compiler (VS). To fix this problem, this CL moves the definition of ScopedDataPipeConsumerHandle::Context to the header file. ---- e:\b\c\b\win\src\base\memory\ref_counted.h(402): error C2027: use of undefined type 'content::WebDataConsumerHandleImpl::Context' e:\b\c\b\win\src\content\child\web_data_consumer_handle_impl.h(22): note: see declaration of 'content::WebDataConsumerHandleImpl::Context' e:\b\c\b\win\src\base\memory\ref_counted.h(401): note: while compiling class template member function 'void scoped_refptr<content::WebDataConsumerHandleImpl::Context>::AddRef(T *)' with [ T=content::WebDataConsumerHandleImpl::Context ] e:\b\c\b\win\src\base\memory\ref_counted.h(285): note: see reference to function template instantiation 'void scoped_refptr<content::WebDataConsumerHandleImpl::Context>::AddRef(T *)' being compiled with [ T=content::WebDataConsumerHandleImpl::Context ] e:\b\c\b\win\src\content\child\web_data_consumer_handle_impl.h(43): note: see reference to class template instantiation 'scoped_refptr<content::WebDataConsumerHandleImpl::Context>' being compiled e:\b\c\b\win\src\base\memory\ref_counted.h(402): error C2227: left of '->AddRef' must point to class/struct/union/generic type --- https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_com... BUG=649558 ========== to ========== Move the definition of ScopedDataPipeConsumerHandle::Context to the header file. When I tried to include "web_data_consumer_handle_impl.h" from service_worker_context_client.cc in https://codereview.chromium.org/2416843002/, I saw the following error. I think this is a bug of a compiler (VS). To fix this problem, this CL moves the definition of ScopedDataPipeConsumerHandle::Context to the header file. ---- e:\b\c\b\win\src\base\memory\ref_counted.h(402): error C2027: use of undefined type 'content::WebDataConsumerHandleImpl::Context' e:\b\c\b\win\src\content\child\web_data_consumer_handle_impl.h(22): note: see declaration of 'content::WebDataConsumerHandleImpl::Context' e:\b\c\b\win\src\base\memory\ref_counted.h(401): note: while compiling class template member function 'void scoped_refptr<content::WebDataConsumerHandleImpl::Context>::AddRef(T *)' with [ T=content::WebDataConsumerHandleImpl::Context ] e:\b\c\b\win\src\base\memory\ref_counted.h(285): note: see reference to function template instantiation 'void scoped_refptr<content::WebDataConsumerHandleImpl::Context>::AddRef(T *)' being compiled with [ T=content::WebDataConsumerHandleImpl::Context ] e:\b\c\b\win\src\content\child\web_data_consumer_handle_impl.h(43): note: see reference to class template instantiation 'scoped_refptr<content::WebDataConsumerHandleImpl::Context>' being compiled e:\b\c\b\win\src\base\memory\ref_counted.h(402): error C2227: left of '->AddRef' must point to class/struct/union/generic type --- https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_com... BUG=649558 ==========
Description was changed from ========== Move the definition of ScopedDataPipeConsumerHandle::Context to the header file. When I tried to include "web_data_consumer_handle_impl.h" from service_worker_context_client.cc in https://codereview.chromium.org/2416843002/, I saw the following error. I think this is a bug of a compiler (VS). To fix this problem, this CL moves the definition of ScopedDataPipeConsumerHandle::Context to the header file. ---- e:\b\c\b\win\src\base\memory\ref_counted.h(402): error C2027: use of undefined type 'content::WebDataConsumerHandleImpl::Context' e:\b\c\b\win\src\content\child\web_data_consumer_handle_impl.h(22): note: see declaration of 'content::WebDataConsumerHandleImpl::Context' e:\b\c\b\win\src\base\memory\ref_counted.h(401): note: while compiling class template member function 'void scoped_refptr<content::WebDataConsumerHandleImpl::Context>::AddRef(T *)' with [ T=content::WebDataConsumerHandleImpl::Context ] e:\b\c\b\win\src\base\memory\ref_counted.h(285): note: see reference to function template instantiation 'void scoped_refptr<content::WebDataConsumerHandleImpl::Context>::AddRef(T *)' being compiled with [ T=content::WebDataConsumerHandleImpl::Context ] e:\b\c\b\win\src\content\child\web_data_consumer_handle_impl.h(43): note: see reference to class template instantiation 'scoped_refptr<content::WebDataConsumerHandleImpl::Context>' being compiled e:\b\c\b\win\src\base\memory\ref_counted.h(402): error C2227: left of '->AddRef' must point to class/struct/union/generic type --- https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_com... BUG=649558 ========== to ========== Move the definition of ScopedDataPipeConsumerHandle::Context to the header file. When I tried to include "web_data_consumer_handle_impl.h" from service_worker_context_client.cc in https://codereview.chromium.org/2416843002/, I saw the following compile error on windows. I think this is a bug of a compiler (VS). To fix this problem, this CL moves the definition of ScopedDataPipeConsumerHandle::Context to the header file. ---- e:\b\c\b\win\src\base\memory\ref_counted.h(402): error C2027: use of undefined type 'content::WebDataConsumerHandleImpl::Context' e:\b\c\b\win\src\content\child\web_data_consumer_handle_impl.h(22): note: see declaration of 'content::WebDataConsumerHandleImpl::Context' e:\b\c\b\win\src\base\memory\ref_counted.h(401): note: while compiling class template member function 'void scoped_refptr<content::WebDataConsumerHandleImpl::Context>::AddRef(T *)' with [ T=content::WebDataConsumerHandleImpl::Context ] e:\b\c\b\win\src\base\memory\ref_counted.h(285): note: see reference to function template instantiation 'void scoped_refptr<content::WebDataConsumerHandleImpl::Context>::AddRef(T *)' being compiled with [ T=content::WebDataConsumerHandleImpl::Context ] e:\b\c\b\win\src\content\child\web_data_consumer_handle_impl.h(43): note: see reference to class template instantiation 'scoped_refptr<content::WebDataConsumerHandleImpl::Context>' being compiled e:\b\c\b\win\src\base\memory\ref_counted.h(402): error C2227: left of '->AddRef' must point to class/struct/union/generic type --- https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_com... BUG=649558 ==========
Description was changed from ========== Move the definition of ScopedDataPipeConsumerHandle::Context to the header file. When I tried to include "web_data_consumer_handle_impl.h" from service_worker_context_client.cc in https://codereview.chromium.org/2416843002/, I saw the following compile error on windows. I think this is a bug of a compiler (VS). To fix this problem, this CL moves the definition of ScopedDataPipeConsumerHandle::Context to the header file. ---- e:\b\c\b\win\src\base\memory\ref_counted.h(402): error C2027: use of undefined type 'content::WebDataConsumerHandleImpl::Context' e:\b\c\b\win\src\content\child\web_data_consumer_handle_impl.h(22): note: see declaration of 'content::WebDataConsumerHandleImpl::Context' e:\b\c\b\win\src\base\memory\ref_counted.h(401): note: while compiling class template member function 'void scoped_refptr<content::WebDataConsumerHandleImpl::Context>::AddRef(T *)' with [ T=content::WebDataConsumerHandleImpl::Context ] e:\b\c\b\win\src\base\memory\ref_counted.h(285): note: see reference to function template instantiation 'void scoped_refptr<content::WebDataConsumerHandleImpl::Context>::AddRef(T *)' being compiled with [ T=content::WebDataConsumerHandleImpl::Context ] e:\b\c\b\win\src\content\child\web_data_consumer_handle_impl.h(43): note: see reference to class template instantiation 'scoped_refptr<content::WebDataConsumerHandleImpl::Context>' being compiled e:\b\c\b\win\src\base\memory\ref_counted.h(402): error C2227: left of '->AddRef' must point to class/struct/union/generic type --- https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_com... BUG=649558 ========== to ========== Move the definition of ScopedDataPipeConsumerHandle::Context to the header file. When I tried to include "web_data_consumer_handle_impl.h" from service_worker_context_client.cc in https://codereview.chromium.org/2416843002/, I saw the following compile error on windows. I think this is a bug of a compiler (VS). To fix this problem, this CL moves the definition of ScopedDataPipeConsumerHandle::Context to the header file. ---- e:\b\c\b\win\src\base\memory\ref_counted.h(402): error C2027: use of undefined type 'content::WebDataConsumerHandleImpl::Context' e:\b\c\b\win\src\content\child\web_data_consumer_handle_impl.h(22): note: see declaration of 'content::WebDataConsumerHandleImpl::Context' e:\b\c\b\win\src\base\memory\ref_counted.h(401): note: while compiling class template member function 'void scoped_refptr<content::WebDataConsumerHandleImpl::Context>::AddRef(T *)' with [ T=content::WebDataConsumerHandleImpl::Context ] e:\b\c\b\win\src\base\memory\ref_counted.h(285): note: see reference to function template instantiation 'void scoped_refptr<content::WebDataConsumerHandleImpl::Context>::AddRef(T *)' being compiled with [ T=content::WebDataConsumerHandleImpl::Context ] e:\b\c\b\win\src\content\child\web_data_consumer_handle_impl.h(43): note: see reference to class template instantiation 'scoped_refptr<content::WebDataConsumerHandleImpl::Context>' being compiled e:\b\c\b\win\src\base\memory\ref_counted.h(402): error C2227: left of '->AddRef' must point to class/struct/union/generic type --- https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_com... BUG=649558 ==========
Description was changed from ========== Move the definition of ScopedDataPipeConsumerHandle::Context to the header file. When I tried to include "web_data_consumer_handle_impl.h" from service_worker_context_client.cc in https://codereview.chromium.org/2416843002/, I saw the following compile error on windows. I think this is a bug of a compiler (VS). To fix this problem, this CL moves the definition of ScopedDataPipeConsumerHandle::Context to the header file. ---- e:\b\c\b\win\src\base\memory\ref_counted.h(402): error C2027: use of undefined type 'content::WebDataConsumerHandleImpl::Context' e:\b\c\b\win\src\content\child\web_data_consumer_handle_impl.h(22): note: see declaration of 'content::WebDataConsumerHandleImpl::Context' e:\b\c\b\win\src\base\memory\ref_counted.h(401): note: while compiling class template member function 'void scoped_refptr<content::WebDataConsumerHandleImpl::Context>::AddRef(T *)' with [ T=content::WebDataConsumerHandleImpl::Context ] e:\b\c\b\win\src\base\memory\ref_counted.h(285): note: see reference to function template instantiation 'void scoped_refptr<content::WebDataConsumerHandleImpl::Context>::AddRef(T *)' being compiled with [ T=content::WebDataConsumerHandleImpl::Context ] e:\b\c\b\win\src\content\child\web_data_consumer_handle_impl.h(43): note: see reference to class template instantiation 'scoped_refptr<content::WebDataConsumerHandleImpl::Context>' being compiled e:\b\c\b\win\src\base\memory\ref_counted.h(402): error C2227: left of '->AddRef' must point to class/struct/union/generic type --- https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_com... BUG=649558 ========== to ========== Move the definition of ScopedDataPipeConsumerHandle::Context to the header file. When I tried to include "web_data_consumer_handle_impl.h" from service_worker_context_client.cc in https://codereview.chromium.org/2416843002/, I saw the following compile error on windows. I think this is a bug of a compiler (VS). To fix this problem, this CL moves the definition of ScopedDataPipeConsumerHandle::Context to the header file. ---- e:\b\c\b\win\src\base\memory\ref_counted.h(402): error C2027: use of undefined type 'content::WebDataConsumerHandleImpl::Context' e:\b\c\b\win\src\content\child\web_data_consumer_handle_impl.h(22): note: see declaration of 'content::WebDataConsumerHandleImpl::Context' e:\b\c\b\win\src\base\memory\ref_counted.h(401): note: while compiling class template member function 'void scoped_refptr<content::WebDataConsumerHandleImpl::Context>::AddRef(T *)' with [ T=content::WebDataConsumerHandleImpl::Context ] e:\b\c\b\win\src\base\memory\ref_counted.h(285): note: see reference to function template instantiation 'void scoped_refptr<content::WebDataConsumerHandleImpl::Context>::AddRef(T *)' being compiled with [ T=content::WebDataConsumerHandleImpl::Context ] e:\b\c\b\win\src\content\child\web_data_consumer_handle_impl.h(43): note: see reference to class template instantiation 'scoped_refptr<content::WebDataConsumerHandleImpl::Context>' being compiled e:\b\c\b\win\src\base\memory\ref_counted.h(402): error C2227: left of '->AddRef' must point to class/struct/union/generic type --- https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_com... BUG=649558 ==========
Description was changed from ========== Move the definition of ScopedDataPipeConsumerHandle::Context to the header file. When I tried to include "web_data_consumer_handle_impl.h" from service_worker_context_client.cc in https://codereview.chromium.org/2416843002/, I saw the following compile error on windows. I think this is a bug of a compiler (VS). To fix this problem, this CL moves the definition of ScopedDataPipeConsumerHandle::Context to the header file. ---- e:\b\c\b\win\src\base\memory\ref_counted.h(402): error C2027: use of undefined type 'content::WebDataConsumerHandleImpl::Context' e:\b\c\b\win\src\content\child\web_data_consumer_handle_impl.h(22): note: see declaration of 'content::WebDataConsumerHandleImpl::Context' e:\b\c\b\win\src\base\memory\ref_counted.h(401): note: while compiling class template member function 'void scoped_refptr<content::WebDataConsumerHandleImpl::Context>::AddRef(T *)' with [ T=content::WebDataConsumerHandleImpl::Context ] e:\b\c\b\win\src\base\memory\ref_counted.h(285): note: see reference to function template instantiation 'void scoped_refptr<content::WebDataConsumerHandleImpl::Context>::AddRef(T *)' being compiled with [ T=content::WebDataConsumerHandleImpl::Context ] e:\b\c\b\win\src\content\child\web_data_consumer_handle_impl.h(43): note: see reference to class template instantiation 'scoped_refptr<content::WebDataConsumerHandleImpl::Context>' being compiled e:\b\c\b\win\src\base\memory\ref_counted.h(402): error C2227: left of '->AddRef' must point to class/struct/union/generic type --- https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_com... BUG=649558 ========== to ========== Move the definition of ScopedDataPipeConsumerHandle::Context to the header file. When I tried to include web_data_consumer_handle_impl.h from service_worker_context_client.cc in https://codereview.chromium.org/2416843002/, I saw the following compile error on windows. I think this is a bug of a compiler (VS). To fix this problem, this CL moves the definition of ScopedDataPipeConsumerHandle::Context to the header file. ---- e:\b\c\b\win\src\base\memory\ref_counted.h(402): error C2027: use of undefined type 'content::WebDataConsumerHandleImpl::Context' e:\b\c\b\win\src\content\child\web_data_consumer_handle_impl.h(22): note: see declaration of 'content::WebDataConsumerHandleImpl::Context' e:\b\c\b\win\src\base\memory\ref_counted.h(401): note: while compiling class template member function 'void scoped_refptr<content::WebDataConsumerHandleImpl::Context>::AddRef(T *)' with [ T=content::WebDataConsumerHandleImpl::Context ] e:\b\c\b\win\src\base\memory\ref_counted.h(285): note: see reference to function template instantiation 'void scoped_refptr<content::WebDataConsumerHandleImpl::Context>::AddRef(T *)' being compiled with [ T=content::WebDataConsumerHandleImpl::Context ] e:\b\c\b\win\src\content\child\web_data_consumer_handle_impl.h(43): note: see reference to class template instantiation 'scoped_refptr<content::WebDataConsumerHandleImpl::Context>' being compiled e:\b\c\b\win\src\base\memory\ref_counted.h(402): error C2227: left of '->AddRef' must point to class/struct/union/generic type --- https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_com... BUG=649558 ==========
horo@chromium.org changed reviewers: + yhirano@chromium.org
yhirano@ Could you please review this?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Move the definition of ScopedDataPipeConsumerHandle::Context to the header file. When I tried to include web_data_consumer_handle_impl.h from service_worker_context_client.cc in https://codereview.chromium.org/2416843002/, I saw the following compile error on windows. I think this is a bug of a compiler (VS). To fix this problem, this CL moves the definition of ScopedDataPipeConsumerHandle::Context to the header file. ---- e:\b\c\b\win\src\base\memory\ref_counted.h(402): error C2027: use of undefined type 'content::WebDataConsumerHandleImpl::Context' e:\b\c\b\win\src\content\child\web_data_consumer_handle_impl.h(22): note: see declaration of 'content::WebDataConsumerHandleImpl::Context' e:\b\c\b\win\src\base\memory\ref_counted.h(401): note: while compiling class template member function 'void scoped_refptr<content::WebDataConsumerHandleImpl::Context>::AddRef(T *)' with [ T=content::WebDataConsumerHandleImpl::Context ] e:\b\c\b\win\src\base\memory\ref_counted.h(285): note: see reference to function template instantiation 'void scoped_refptr<content::WebDataConsumerHandleImpl::Context>::AddRef(T *)' being compiled with [ T=content::WebDataConsumerHandleImpl::Context ] e:\b\c\b\win\src\content\child\web_data_consumer_handle_impl.h(43): note: see reference to class template instantiation 'scoped_refptr<content::WebDataConsumerHandleImpl::Context>' being compiled e:\b\c\b\win\src\base\memory\ref_counted.h(402): error C2227: left of '->AddRef' must point to class/struct/union/generic type --- https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_com... BUG=649558 ========== to ========== Add DISALLOW_COPY_AND_ASSIGN in web_data_consumer_handle_impl.h. When I tried to include web_data_consumer_handle_impl.h from service_worker_context_client.cc in https://codereview.chromium.org/2416843002/, I saw the following compile error on windows. To avoid this problem, this CL adds DISALLOW_COPY_AND_ASSIGN in web_data_consumer_handle_impl.h. ---- e:\b\c\b\win\src\base\memory\ref_counted.h(402): error C2027: use of undefined type 'content::WebDataConsumerHandleImpl::Context' e:\b\c\b\win\src\content\child\web_data_consumer_handle_impl.h(22): note: see declaration of 'content::WebDataConsumerHandleImpl::Context' e:\b\c\b\win\src\base\memory\ref_counted.h(401): note: while compiling class template member function 'void scoped_refptr<content::WebDataConsumerHandleImpl::Context>::AddRef(T *)' with [ T=content::WebDataConsumerHandleImpl::Context ] e:\b\c\b\win\src\base\memory\ref_counted.h(285): note: see reference to function template instantiation 'void scoped_refptr<content::WebDataConsumerHandleImpl::Context>::AddRef(T *)' being compiled with [ T=content::WebDataConsumerHandleImpl::Context ] e:\b\c\b\win\src\content\child\web_data_consumer_handle_impl.h(43): note: see reference to class template instantiation 'scoped_refptr<content::WebDataConsumerHandleImpl::Context>' being compiled e:\b\c\b\win\src\base\memory\ref_counted.h(402): error C2227: left of '->AddRef' must point to class/struct/union/generic type --- https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_com... BUG=649558 ==========
Description was changed from ========== Add DISALLOW_COPY_AND_ASSIGN in web_data_consumer_handle_impl.h. When I tried to include web_data_consumer_handle_impl.h from service_worker_context_client.cc in https://codereview.chromium.org/2416843002/, I saw the following compile error on windows. To avoid this problem, this CL adds DISALLOW_COPY_AND_ASSIGN in web_data_consumer_handle_impl.h. ---- e:\b\c\b\win\src\base\memory\ref_counted.h(402): error C2027: use of undefined type 'content::WebDataConsumerHandleImpl::Context' e:\b\c\b\win\src\content\child\web_data_consumer_handle_impl.h(22): note: see declaration of 'content::WebDataConsumerHandleImpl::Context' e:\b\c\b\win\src\base\memory\ref_counted.h(401): note: while compiling class template member function 'void scoped_refptr<content::WebDataConsumerHandleImpl::Context>::AddRef(T *)' with [ T=content::WebDataConsumerHandleImpl::Context ] e:\b\c\b\win\src\base\memory\ref_counted.h(285): note: see reference to function template instantiation 'void scoped_refptr<content::WebDataConsumerHandleImpl::Context>::AddRef(T *)' being compiled with [ T=content::WebDataConsumerHandleImpl::Context ] e:\b\c\b\win\src\content\child\web_data_consumer_handle_impl.h(43): note: see reference to class template instantiation 'scoped_refptr<content::WebDataConsumerHandleImpl::Context>' being compiled e:\b\c\b\win\src\base\memory\ref_counted.h(402): error C2227: left of '->AddRef' must point to class/struct/union/generic type --- https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_com... BUG=649558 ========== to ========== Add DISALLOW_COPY_AND_ASSIGN in web_data_consumer_handle_impl.h. When I tried to include web_data_consumer_handle_impl.h from service_worker_context_client.cc in https://codereview.chromium.org/2416843002/, I saw the following compile error on windows. To avoid this problem, this CL adds DISALLOW_COPY_AND_ASSIGN in web_data_consumer_handle_impl.h. ---- e:\b\c\b\win\src\base\memory\ref_counted.h(402): error C2027: use of undefined type 'content::WebDataConsumerHandleImpl::Context' e:\b\c\b\win\src\content\child\web_data_consumer_handle_impl.h(22): note: see declaration of 'content::WebDataConsumerHandleImpl::Context' e:\b\c\b\win\src\base\memory\ref_counted.h(401): note: while compiling class template member function 'void scoped_refptr<content::WebDataConsumerHandleImpl::Context>::AddRef(T *)' with [ T=content::WebDataConsumerHandleImpl::Context ] e:\b\c\b\win\src\base\memory\ref_counted.h(285): note: see reference to function template instantiation 'void scoped_refptr<content::WebDataConsumerHandleImpl::Context>::AddRef(T *)' being compiled with [ T=content::WebDataConsumerHandleImpl::Context ] e:\b\c\b\win\src\content\child\web_data_consumer_handle_impl.h(43): note: see reference to class template instantiation 'scoped_refptr<content::WebDataConsumerHandleImpl::Context>' being compiled e:\b\c\b\win\src\base\memory\ref_counted.h(402): error C2227: left of '->AddRef' must point to class/struct/union/generic type --- https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_com... BUG=649558 ==========
The CQ bit was checked by horo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/10/17 07:09:04, horo wrote: > yhirano@ > Could you please review this? As I talked offline, I uploaded Patch Set 3 which just adds DISALLOW_COPY_AND_ASSIGN in web_data_consumer_handle_impl.h.
https://codereview.chromium.org/2426483002/diff/40001/content/child/web_data_... File content/child/web_data_consumer_handle_impl.h (right): https://codereview.chromium.org/2426483002/diff/40001/content/child/web_data_... content/child/web_data_consumer_handle_impl.h:21: public: Do you need to move this public: statement?
The CQ bit was checked by horo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2426483002/diff/40001/content/child/web_data_... File content/child/web_data_consumer_handle_impl.h (right): https://codereview.chromium.org/2426483002/diff/40001/content/child/web_data_... content/child/web_data_consumer_handle_impl.h:21: public: On 2016/10/17 08:44:05, yhirano wrote: > Do you need to move this public: statement? No. Moved. Done.
lgtm
horo@chromium.org changed reviewers: + clamy@chromium.org
clamy@ Please review this. Thank you.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
horo@chromium.org changed reviewers: + avi@chromium.org
Ah, clamy@ is ooo :) avi@ Could you please review this?
LGTM with a bit of extra space. https://codereview.chromium.org/2426483002/diff/60001/content/child/web_data_... File content/child/web_data_consumer_handle_impl.h (right): https://codereview.chromium.org/2426483002/diff/60001/content/child/web_data_... content/child/web_data_consumer_handle_impl.h:46: DISALLOW_COPY_AND_ASSIGN(ReaderImpl); A blank line before this one, please. https://codereview.chromium.org/2426483002/diff/60001/content/child/web_data_... content/child/web_data_consumer_handle_impl.h:57: DISALLOW_COPY_AND_ASSIGN(WebDataConsumerHandleImpl); Same here.
Thank you! https://codereview.chromium.org/2426483002/diff/60001/content/child/web_data_... File content/child/web_data_consumer_handle_impl.h (right): https://codereview.chromium.org/2426483002/diff/60001/content/child/web_data_... content/child/web_data_consumer_handle_impl.h:46: DISALLOW_COPY_AND_ASSIGN(ReaderImpl); On 2016/10/18 14:57:57, Avi wrote: > A blank line before this one, please. Done. https://codereview.chromium.org/2426483002/diff/60001/content/child/web_data_... content/child/web_data_consumer_handle_impl.h:57: DISALLOW_COPY_AND_ASSIGN(WebDataConsumerHandleImpl); On 2016/10/18 14:57:57, Avi wrote: > Same here. Done.
The CQ bit was checked by horo@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org, yhirano@chromium.org Link to the patchset: https://codereview.chromium.org/2426483002/#ps80001 (title: "add blank lines")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add DISALLOW_COPY_AND_ASSIGN in web_data_consumer_handle_impl.h. When I tried to include web_data_consumer_handle_impl.h from service_worker_context_client.cc in https://codereview.chromium.org/2416843002/, I saw the following compile error on windows. To avoid this problem, this CL adds DISALLOW_COPY_AND_ASSIGN in web_data_consumer_handle_impl.h. ---- e:\b\c\b\win\src\base\memory\ref_counted.h(402): error C2027: use of undefined type 'content::WebDataConsumerHandleImpl::Context' e:\b\c\b\win\src\content\child\web_data_consumer_handle_impl.h(22): note: see declaration of 'content::WebDataConsumerHandleImpl::Context' e:\b\c\b\win\src\base\memory\ref_counted.h(401): note: while compiling class template member function 'void scoped_refptr<content::WebDataConsumerHandleImpl::Context>::AddRef(T *)' with [ T=content::WebDataConsumerHandleImpl::Context ] e:\b\c\b\win\src\base\memory\ref_counted.h(285): note: see reference to function template instantiation 'void scoped_refptr<content::WebDataConsumerHandleImpl::Context>::AddRef(T *)' being compiled with [ T=content::WebDataConsumerHandleImpl::Context ] e:\b\c\b\win\src\content\child\web_data_consumer_handle_impl.h(43): note: see reference to class template instantiation 'scoped_refptr<content::WebDataConsumerHandleImpl::Context>' being compiled e:\b\c\b\win\src\base\memory\ref_counted.h(402): error C2227: left of '->AddRef' must point to class/struct/union/generic type --- https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_com... BUG=649558 ========== to ========== Add DISALLOW_COPY_AND_ASSIGN in web_data_consumer_handle_impl.h. When I tried to include web_data_consumer_handle_impl.h from service_worker_context_client.cc in https://codereview.chromium.org/2416843002/, I saw the following compile error on windows. To avoid this problem, this CL adds DISALLOW_COPY_AND_ASSIGN in web_data_consumer_handle_impl.h. ---- e:\b\c\b\win\src\base\memory\ref_counted.h(402): error C2027: use of undefined type 'content::WebDataConsumerHandleImpl::Context' e:\b\c\b\win\src\content\child\web_data_consumer_handle_impl.h(22): note: see declaration of 'content::WebDataConsumerHandleImpl::Context' e:\b\c\b\win\src\base\memory\ref_counted.h(401): note: while compiling class template member function 'void scoped_refptr<content::WebDataConsumerHandleImpl::Context>::AddRef(T *)' with [ T=content::WebDataConsumerHandleImpl::Context ] e:\b\c\b\win\src\base\memory\ref_counted.h(285): note: see reference to function template instantiation 'void scoped_refptr<content::WebDataConsumerHandleImpl::Context>::AddRef(T *)' being compiled with [ T=content::WebDataConsumerHandleImpl::Context ] e:\b\c\b\win\src\content\child\web_data_consumer_handle_impl.h(43): note: see reference to class template instantiation 'scoped_refptr<content::WebDataConsumerHandleImpl::Context>' being compiled e:\b\c\b\win\src\base\memory\ref_counted.h(402): error C2227: left of '->AddRef' must point to class/struct/union/generic type --- https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_com... BUG=649558 ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== Add DISALLOW_COPY_AND_ASSIGN in web_data_consumer_handle_impl.h. When I tried to include web_data_consumer_handle_impl.h from service_worker_context_client.cc in https://codereview.chromium.org/2416843002/, I saw the following compile error on windows. To avoid this problem, this CL adds DISALLOW_COPY_AND_ASSIGN in web_data_consumer_handle_impl.h. ---- e:\b\c\b\win\src\base\memory\ref_counted.h(402): error C2027: use of undefined type 'content::WebDataConsumerHandleImpl::Context' e:\b\c\b\win\src\content\child\web_data_consumer_handle_impl.h(22): note: see declaration of 'content::WebDataConsumerHandleImpl::Context' e:\b\c\b\win\src\base\memory\ref_counted.h(401): note: while compiling class template member function 'void scoped_refptr<content::WebDataConsumerHandleImpl::Context>::AddRef(T *)' with [ T=content::WebDataConsumerHandleImpl::Context ] e:\b\c\b\win\src\base\memory\ref_counted.h(285): note: see reference to function template instantiation 'void scoped_refptr<content::WebDataConsumerHandleImpl::Context>::AddRef(T *)' being compiled with [ T=content::WebDataConsumerHandleImpl::Context ] e:\b\c\b\win\src\content\child\web_data_consumer_handle_impl.h(43): note: see reference to class template instantiation 'scoped_refptr<content::WebDataConsumerHandleImpl::Context>' being compiled e:\b\c\b\win\src\base\memory\ref_counted.h(402): error C2227: left of '->AddRef' must point to class/struct/union/generic type --- https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_com... BUG=649558 ========== to ========== Add DISALLOW_COPY_AND_ASSIGN in web_data_consumer_handle_impl.h. When I tried to include web_data_consumer_handle_impl.h from service_worker_context_client.cc in https://codereview.chromium.org/2416843002/, I saw the following compile error on windows. To avoid this problem, this CL adds DISALLOW_COPY_AND_ASSIGN in web_data_consumer_handle_impl.h. ---- e:\b\c\b\win\src\base\memory\ref_counted.h(402): error C2027: use of undefined type 'content::WebDataConsumerHandleImpl::Context' e:\b\c\b\win\src\content\child\web_data_consumer_handle_impl.h(22): note: see declaration of 'content::WebDataConsumerHandleImpl::Context' e:\b\c\b\win\src\base\memory\ref_counted.h(401): note: while compiling class template member function 'void scoped_refptr<content::WebDataConsumerHandleImpl::Context>::AddRef(T *)' with [ T=content::WebDataConsumerHandleImpl::Context ] e:\b\c\b\win\src\base\memory\ref_counted.h(285): note: see reference to function template instantiation 'void scoped_refptr<content::WebDataConsumerHandleImpl::Context>::AddRef(T *)' being compiled with [ T=content::WebDataConsumerHandleImpl::Context ] e:\b\c\b\win\src\content\child\web_data_consumer_handle_impl.h(43): note: see reference to class template instantiation 'scoped_refptr<content::WebDataConsumerHandleImpl::Context>' being compiled e:\b\c\b\win\src\base\memory\ref_counted.h(402): error C2227: left of '->AddRef' must point to class/struct/union/generic type --- https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_com... BUG=649558 Committed: https://crrev.com/77e1af6093d3634a5367cfc090e531e5a72cd0f4 Cr-Commit-Position: refs/heads/master@{#425989} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/77e1af6093d3634a5367cfc090e531e5a72cd0f4 Cr-Commit-Position: refs/heads/master@{#425989} |
