Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2426483002: Add DISALLOW_COPY_AND_ASSIGN in web_data_consumer_handle_impl.h. (Closed)

Created:
4 years, 2 months ago by horo
Modified:
4 years, 2 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add DISALLOW_COPY_AND_ASSIGN in web_data_consumer_handle_impl.h. When I tried to include web_data_consumer_handle_impl.h from service_worker_context_client.cc in https://codereview.chromium.org/2416843002/, I saw the following compile error on windows. To avoid this problem, this CL adds DISALLOW_COPY_AND_ASSIGN in web_data_consumer_handle_impl.h. ---- e:\b\c\b\win\src\base\memory\ref_counted.h(402): error C2027: use of undefined type 'content::WebDataConsumerHandleImpl::Context' e:\b\c\b\win\src\content\child\web_data_consumer_handle_impl.h(22): note: see declaration of 'content::WebDataConsumerHandleImpl::Context' e:\b\c\b\win\src\base\memory\ref_counted.h(401): note: while compiling class template member function 'void scoped_refptr<content::WebDataConsumerHandleImpl::Context>::AddRef(T *)' with [ T=content::WebDataConsumerHandleImpl::Context ] e:\b\c\b\win\src\base\memory\ref_counted.h(285): note: see reference to function template instantiation 'void scoped_refptr<content::WebDataConsumerHandleImpl::Context>::AddRef(T *)' being compiled with [ T=content::WebDataConsumerHandleImpl::Context ] e:\b\c\b\win\src\content\child\web_data_consumer_handle_impl.h(43): note: see reference to class template instantiation 'scoped_refptr<content::WebDataConsumerHandleImpl::Context>' being compiled e:\b\c\b\win\src\base\memory\ref_counted.h(402): error C2227: left of '->AddRef' must point to class/struct/union/generic type --- https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/277294/steps/compile%20%28with%20patch%29/logs/stdio BUG=649558 Committed: https://crrev.com/77e1af6093d3634a5367cfc090e531e5a72cd0f4 Cr-Commit-Position: refs/heads/master@{#425989}

Patch Set 1 #

Patch Set 2 : unset-upstream #

Patch Set 3 : Add DISALLOW_COPY_AND_ASSIGN in web_data_consumer_handle_impl.h #

Total comments: 2

Patch Set 4 : incorporated yhirano's comment #

Total comments: 4

Patch Set 5 : add blank lines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M content/child/web_data_consumer_handle_impl.h View 1 2 3 4 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 39 (27 generated)
horo
yhirano@ Could you please review this?
4 years, 2 months ago (2016-10-17 07:09:04 UTC) #12
horo
On 2016/10/17 07:09:04, horo wrote: > yhirano@ > Could you please review this? As I ...
4 years, 2 months ago (2016-10-17 08:33:46 UTC) #19
yhirano
https://codereview.chromium.org/2426483002/diff/40001/content/child/web_data_consumer_handle_impl.h File content/child/web_data_consumer_handle_impl.h (right): https://codereview.chromium.org/2426483002/diff/40001/content/child/web_data_consumer_handle_impl.h#newcode21 content/child/web_data_consumer_handle_impl.h:21: public: Do you need to move this public: statement?
4 years, 2 months ago (2016-10-17 08:44:05 UTC) #20
horo
https://codereview.chromium.org/2426483002/diff/40001/content/child/web_data_consumer_handle_impl.h File content/child/web_data_consumer_handle_impl.h (right): https://codereview.chromium.org/2426483002/diff/40001/content/child/web_data_consumer_handle_impl.h#newcode21 content/child/web_data_consumer_handle_impl.h:21: public: On 2016/10/17 08:44:05, yhirano wrote: > Do you ...
4 years, 2 months ago (2016-10-17 08:59:46 UTC) #23
yhirano
lgtm
4 years, 2 months ago (2016-10-17 09:02:39 UTC) #24
horo
clamy@ Please review this. Thank you.
4 years, 2 months ago (2016-10-17 09:28:27 UTC) #26
horo
Ah, clamy@ is ooo :) avi@ Could you please review this?
4 years, 2 months ago (2016-10-18 14:54:17 UTC) #30
Avi (use Gerrit)
LGTM with a bit of extra space. https://codereview.chromium.org/2426483002/diff/60001/content/child/web_data_consumer_handle_impl.h File content/child/web_data_consumer_handle_impl.h (right): https://codereview.chromium.org/2426483002/diff/60001/content/child/web_data_consumer_handle_impl.h#newcode46 content/child/web_data_consumer_handle_impl.h:46: DISALLOW_COPY_AND_ASSIGN(ReaderImpl); A ...
4 years, 2 months ago (2016-10-18 14:57:57 UTC) #31
horo
Thank you! https://codereview.chromium.org/2426483002/diff/60001/content/child/web_data_consumer_handle_impl.h File content/child/web_data_consumer_handle_impl.h (right): https://codereview.chromium.org/2426483002/diff/60001/content/child/web_data_consumer_handle_impl.h#newcode46 content/child/web_data_consumer_handle_impl.h:46: DISALLOW_COPY_AND_ASSIGN(ReaderImpl); On 2016/10/18 14:57:57, Avi wrote: > ...
4 years, 2 months ago (2016-10-18 15:01:39 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2426483002/80001
4 years, 2 months ago (2016-10-18 15:02:06 UTC) #35
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 2 months ago (2016-10-18 16:48:38 UTC) #37
commit-bot: I haz the power
4 years, 2 months ago (2016-10-18 16:51:43 UTC) #39
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/77e1af6093d3634a5367cfc090e531e5a72cd0f4
Cr-Commit-Position: refs/heads/master@{#425989}

Powered by Google App Engine
This is Rietveld 408576698