Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 242643009: Added DISALLOW_COPY_AND_ASSIGN to disable copy/assign. (Closed)

Created:
6 years, 8 months ago by ramant (doing other things)
Modified:
6 years, 8 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, jar (doing other things)
Visibility:
Public.

Description

Added DISALLOW_COPY_AND_ASSIGN to disable copy/assign. http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Copy_Constructors#Copy_Constructors Sorry for missing this before while merging. jar pointed to the above link on Friday and learned from him it is safer to add the above macro whereever possible. Didn't touch .cc files (or *test.cc). These changes are in internal CL: 65311983 Merge internal change: 65311983 R=rch@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265207

Patch Set 1 #

Patch Set 2 : Merging with TOT and internal CL: 65311983 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -2 lines) Patch
M net/quic/congestion_control/available_channel_estimator.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/congestion_control/cube_root.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/congestion_control/rtt_stats.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/congestion_control/tcp_loss_algorithm.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/congestion_control/time_loss_algorithm.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/crypto/aead_base_decrypter.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/crypto/aead_base_encrypter.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/crypto/aes_128_gcm_12_decrypter.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/crypto/aes_128_gcm_12_encrypter.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/crypto/cert_compressor.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/crypto/chacha20_poly1305_decrypter.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/crypto/chacha20_poly1305_encrypter.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/crypto/channel_id.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/crypto/crypto_server_config_protobuf.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/crypto/crypto_utils.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/crypto/null_decrypter.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/crypto/null_encrypter.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/crypto/p256_key_exchange.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/crypto/quic_crypto_server_config.h View 1 2 chunks +5 lines, -0 lines 0 comments Download
M net/quic/crypto/quic_server_info.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/crypto/scoped_evp_aead_ctx.h View 2 chunks +4 lines, -0 lines 0 comments Download
M net/quic/crypto/source_address_token.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/crypto/strike_register.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/iovector.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/quic_ack_notifier.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/quic_ack_notifier_manager.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M net/quic/quic_clock.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/quic_connection_logger.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_crypto_server_stream.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/quic_data_reader.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/quic_data_writer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/quic_default_packet_writer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/quic_http_stream.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/quic_received_packet_manager.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/quic_sent_entropy_manager.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/quic_socket_address_coder.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_stream_sequencer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/quic_utils.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/spdy_utils.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/test_tools/mock_clock.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/test_tools/mock_crypto_client_stream.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/test_tools/mock_crypto_client_stream_factory.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/test_tools/mock_random.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_config_peer.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 1 8 chunks +19 lines, -0 lines 0 comments Download
M net/tools/quic/quic_default_packet_writer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/tools/quic/quic_epoll_clock.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M net/tools/quic/quic_socket_utils.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/tools/quic/quic_spdy_client_stream.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/tools/quic/quic_spdy_server_stream.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/tools/quic/spdy_utils.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/tools/quic/test_tools/mock_epoll_server.h View 2 chunks +4 lines, -0 lines 0 comments Download
M net/tools/quic/test_tools/mock_quic_dispatcher.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/tools/quic/test_tools/quic_client_peer.h View 2 chunks +5 lines, -0 lines 0 comments Download
M net/tools/quic/test_tools/quic_dispatcher_peer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/tools/quic/test_tools/quic_server_peer.h View 2 chunks +5 lines, -0 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.h View 2 chunks +4 lines, -0 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_utils.h View 1 5 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
ramant (doing other things)
6 years, 8 months ago (2014-04-20 03:11:22 UTC) #1
Ryan Hamilton
Are all of these in the internal repository already?
6 years, 8 months ago (2014-04-21 03:29:30 UTC) #2
ramant (doing other things)
Hi Ryan, Made the corresponding changes into the internal source tree also. thanks raman
6 years, 8 months ago (2014-04-21 19:25:03 UTC) #3
Ryan Hamilton
lgtm
6 years, 8 months ago (2014-04-22 03:25:30 UTC) #4
ramant (doing other things)
The CQ bit was checked by rtenneti@chromium.org
6 years, 8 months ago (2014-04-22 05:22:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/242643009/20001
6 years, 8 months ago (2014-04-22 05:23:21 UTC) #6
commit-bot: I haz the power
6 years, 8 months ago (2014-04-22 07:56:55 UTC) #7
Message was sent while issue was closed.
Change committed as 265207

Powered by Google App Engine
This is Rietveld 408576698