content/renderer/drop_data_builder.cc - Issue 242643004: Support drag and drop of files with filesystem: URL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/drop_data_builder.cc

Issue 242643004: Support drag and drop of files with filesystem: URL (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix SEGV during tests Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/drop_data_builder.cc

diff --git a/content/renderer/drop_data_builder.cc b/content/renderer/drop_data_builder.cc

index 14b4dcdf61aada0e1ba0501891f1ebfdc3573dfb..395c2b55f378a95134fc7c166197931a84b3d298 100644

--- a/content/renderer/drop_data_builder.cc

+++ b/content/renderer/drop_data_builder.cc

@@ -59,8 +59,13 @@ DropData DropDataBuilder::Build(const WebDragData& drag_data) {

base::FilePath::FromUTF16Unsafe(item.filenameData),

base::FilePath::FromUTF16Unsafe(item.displayNameData)));

break;

- default: // TODO(hashimoto): Remove this "default".

- NOTREACHED();

+ case WebDragData::Item::StorageTypeFileSystemFile: {

+ DropData::FileSystemFileInfo info;

+ info.url = item.fileSystemURL;

+ info.size = item.fileSystemFileSize;

+ result.file_system_files.push_back(info);

+ break;

+ }

}