Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1490)

Unified Diff: content/browser/web_contents/web_contents_view_aura.cc

Issue 242643004: Support drag and drop of files with filesystem: URL (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix SEGV during tests Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_view_aura.cc
diff --git a/content/browser/web_contents/web_contents_view_aura.cc b/content/browser/web_contents/web_contents_view_aura.cc
index 9062d5d71e9a2589871a4abbb850005f80d91be2..2d77af7823e64895db15db733c28a01e22d5d206 100644
--- a/content/browser/web_contents/web_contents_view_aura.cc
+++ b/content/browser/web_contents/web_contents_view_aura.cc
@@ -294,6 +294,54 @@ void PrepareDragForDownload(
}
#endif // defined(OS_WIN)
+// Returns the CustomFormat to store file system files.
+const ui::OSExchangeData::CustomFormat& GetFileSystemFileCustomFormat() {
+ static const char kFormatString[] = "chromium/x-file-system-files";
+ CR_DEFINE_STATIC_LOCAL(ui::OSExchangeData::CustomFormat,
+ format,
+ (ui::Clipboard::GetFormatType(kFormatString)));
+ return format;
+}
+
+// Writes file system files to the pickle.
+void WriteFileSystemFilesToPickle(
+ const std::vector<DropData::FileSystemFileInfo>& file_system_files,
+ Pickle* pickle) {
+ pickle->WriteUInt64(file_system_files.size());
+ for (size_t i = 0; i < file_system_files.size(); ++i) {
+ pickle->WriteString(file_system_files[i].url.spec());
+ pickle->WriteInt64(file_system_files[i].size);
+ }
+}
+
+// Reads file system files from the pickle.
+bool ReadFileSystemFilesFromPickle(
+ const Pickle& pickle,
+ std::vector<DropData::FileSystemFileInfo>* file_system_files) {
+ PickleIterator iter(pickle);
+
+ uint64 num_files = 0;
+ if (!pickle.ReadUInt64(&iter, &num_files))
+ return false;
+ file_system_files->resize(num_files);
+
+ for (uint64 i = 0; i < num_files; ++i) {
+ std::string url_string;
+ int64 size = 0;
+ if (!pickle.ReadString(&iter, &url_string) ||
+ !pickle.ReadInt64(&iter, &size))
+ return false;
+
+ GURL url(url_string);
+ if (!url.is_valid())
+ return false;
+
+ (*file_system_files)[i].url = url;
+ (*file_system_files)[i].size = size;
+ }
+ return true;
+}
+
// Utility to fill a ui::OSExchangeDataProvider object from DropData.
void PrepareDragData(const DropData& drop_data,
ui::OSExchangeData::Provider* provider,
@@ -320,6 +368,11 @@ void PrepareDragData(const DropData& drop_data,
provider->SetHtml(drop_data.html.string(), drop_data.html_base_url);
if (!drop_data.filenames.empty())
provider->SetFilenames(drop_data.filenames);
+ if (!drop_data.file_system_files.empty()) {
+ Pickle pickle;
+ WriteFileSystemFilesToPickle(drop_data.file_system_files, &pickle);
+ provider->SetPickledData(GetFileSystemFileCustomFormat(), pickle);
+ }
if (!drop_data.custom_data.empty()) {
Pickle pickle;
ui::WriteCustomDataToPickle(drop_data.custom_data, &pickle);
@@ -357,6 +410,11 @@ void PrepareDropData(DropData* drop_data, const ui::OSExchangeData& data) {
data.GetFilenames(&drop_data->filenames);
Pickle pickle;
+ std::vector<DropData::FileSystemFileInfo> file_system_files;
+ if (data.GetPickledData(GetFileSystemFileCustomFormat(), &pickle) &&
+ ReadFileSystemFilesFromPickle(pickle, &file_system_files))
+ drop_data->file_system_files = file_system_files;
+
if (data.GetPickledData(ui::Clipboard::GetWebCustomDataFormatType(), &pickle))
ui::ReadCustomDataIntoMap(
pickle.data(), pickle.size(), &drop_data->custom_data);

Powered by Google App Engine
This is Rietveld 408576698