Propagate errors correctly in Socket.connect

Propagate errors correctly in Socket.connect

socket.port can throw an exception. The error from the
exception, if there is one, has to go to the completer,
not be thrown up the stack, otherwise it may go to the
enclosing Zone rather than e.g. a try ... catch around
await Socket.connetc().

This is a possible fix for the issue below, but it is
tough to say because I don't have a reliable repro.

related #27440

R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/16db33b7a27458fa605ab533101ade4b05ba8e47

[zra, 2016-10-19 21:58:20]

Description was changed from

==========
Propagate errors correctly in Socket.connect

related #27440
==========

to

==========
Propagate errors correctly in Socket.connect

socket.port can throw an exception. The error from the
exception, if there is one, has to go to the completer,
not be thrown up the stack, otherwise it may go to the
enclosing Zone rather than e.g. a try ... catch around
await Socket.connetc().

This is a possible fix for the issue below, but it is
tough to say because I don't have a reliable repro.

related #27440
==========

[zra, 2016-10-19 21:58:52]

zra@google.com changed reviewers:
+ asiva@google.com, sgjesse@google.com

[siva, 2016-10-19 22:08:53]

lgtm

[zra, 2016-10-19 22:13:02]

Description was changed from

==========
Propagate errors correctly in Socket.connect

socket.port can throw an exception. The error from the
exception, if there is one, has to go to the completer,
not be thrown up the stack, otherwise it may go to the
enclosing Zone rather than e.g. a try ... catch around
await Socket.connetc().

This is a possible fix for the issue below, but it is
tough to say because I don't have a reliable repro.

related #27440
==========

to

==========
Propagate errors correctly in Socket.connect

socket.port can throw an exception. The error from the
exception, if there is one, has to go to the completer,
not be thrown up the stack, otherwise it may go to the
enclosing Zone rather than e.g. a try ... catch around
await Socket.connetc().

This is a possible fix for the issue below, but it is
tough to say because I don't have a reliable repro.

related #27440

R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/16db33b7a27458fa605ab533101ade4b05ba8e47
==========

[zra, 2016-10-19 22:13:04]

Committed patchset #1 (id:1) manually as
16db33b7a27458fa605ab533101ade4b05ba8e47 (presubmit successful).