Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Issue 2426213002: VM: Fix another dead-lock in background compiler. (Closed)

Created:
4 years, 2 months ago by Florian Schneider
Modified:
4 years, 2 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Fix another dead-lock in background compiler. Grabbing the lock must always take safepoints into account. Observed as a flaky timeout on standalone/http_launch_test. BUG= R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/197d56d853711bec51b73af7691e1e000a9ef518

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M runtime/vm/isolate.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Florian Schneider
4 years, 2 months ago (2016-10-18 22:53:37 UTC) #3
siva
lgtm
4 years, 2 months ago (2016-10-18 23:46:18 UTC) #4
Florian Schneider
4 years, 2 months ago (2016-10-18 23:53:17 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
197d56d853711bec51b73af7691e1e000a9ef518 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698