Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issue 2426133002: Revert of Switching ExtensionSpecialStoragePolicy::IsStorageDurable to use DurableStorage... (Closed)

Created:
4 years, 2 months ago by dougt
Modified:
4 years, 1 month ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org, markusheintz_, msramek+watch_chromium.org, raymes+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Switching ExtensionSpecialStoragePolicy::IsStorageDurable to use DurableStoragePermissionContext. (patchset #11 id:200001 of https://codereview.chromium.org/2351803002/ ) Reason for revert: Caused issue 656495. Original issue's description: > Switching IsStorageDurable() to use DurableStoragePermissionContext. > > ExtensionSpecialStoragePolicy was using cookies_settings to figure out if the > given origin was allowed to use durable storage. In order to make this work, the > cookies_settings had to use a lower level api (HostContentSettingsMap) to avoid > layer violations. > > We found that we could remove the cookies_settings::IsStorageDurable() and, > instead, just have the ExtensionSpecialStoragePolicy access the > PermissionManager. > > BUG=539538 > R=raymes, jochen, pfeldman > > Committed: https://crrev.com/4a19a66d254415f7afb67d6f3c6e6354f280109d > Cr-Commit-Position: refs/heads/master@{#424165} TBR=jochen@chromium.org,dgrogan@chromium.org,msramek@chromium.org,pfeldman@chromium.org,raymes@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=539538 Committed: https://crrev.com/c93bb7ff88c19875efd7fdb7d8fe7e6538310e67 Cr-Commit-Position: refs/heads/master@{#427244}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -29 lines) Patch
M chrome/browser/browsing_data/cookies_tree_model_unittest.cc View 1 chunk +7 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_special_storage_policy.h View 3 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_special_storage_policy.cc View 7 chunks +9 lines, -16 lines 0 comments Download
M chrome/browser/extensions/extension_special_storage_policy_unittest.cc View 2 chunks +9 lines, -7 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/content_settings/core/browser/cookie_settings.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/content_settings/core/browser/cookie_settings.cc View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
dougt
Created Revert of Switching ExtensionSpecialStoragePolicy::IsStorageDurable to use DurableStoragePermissionContext.
4 years, 2 months ago (2016-10-18 20:45:25 UTC) #2
raymes
lgtm
4 years, 1 month ago (2016-10-25 01:39:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2426133002/1
4 years, 1 month ago (2016-10-25 01:39:57 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-25 02:29:02 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 02:31:04 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c93bb7ff88c19875efd7fdb7d8fe7e6538310e67
Cr-Commit-Position: refs/heads/master@{#427244}

Powered by Google App Engine
This is Rietveld 408576698