Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(378)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: LayoutTests/http/tests/history/cross-origin-replace-history-object-child-expected.txt
Issue
242613009
:
Make window.history property non replaceable (Closed)
Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase
Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
LayoutTests/fast/dom/Window/get-set-properties.html
LayoutTests/fast/dom/Window/get-set-properties-expected.txt
LayoutTests/fast/dom/Window/window-property-shadowing.html
LayoutTests/fast/dom/Window/window-property-shadowing-expected.txt
LayoutTests/fast/js/var-declarations-shadowing.html
LayoutTests/fast/js/var-declarations-shadowing-expected.txt
LayoutTests/http/tests/history/cross-origin-replace-history-object-child-expected.txt
LayoutTests/http/tests/history/resources/cross-origin-replaces-history-object-child-iframe.html
Source/core/frame/Window.idl
View unified diff
|
Download patch
|
Annotate
|
Revision Log
« no previous file with comments
|
« LayoutTests/fast/js/var-declarations-shadowing-expected.txt
('k') |
LayoutTests/http/tests/history/resources/cross-origin-replaces-history-object-child-iframe.html »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 ALERT: PASS: Access to window.frames[0].history threw an exception.
1 ALERT: PASS: Access to window.frames[0].history threw an exception.
2 ALERT: About to shadow child window's history object: [object History]
2 ALERT: About to shadow child window's history object: [object History]
3
ALERT:
Shadowed child
window's history object:
3
ALERT:
Child
window's history object
should not be shadowed
:
[object History]
4 ALERT: PASS: Access to window.frames[0].history threw an exception.
4 ALERT: PASS: Access to window.frames[0].history threw an exception.
5
5
OLD
NEW
« no previous file with comments
|
« LayoutTests/fast/js/var-declarations-shadowing-expected.txt
('k') |
LayoutTests/http/tests/history/resources/cross-origin-replaces-history-object-child-iframe.html »
('j') |
no next file with comments »
Issue 242613009: Make window.history property non replaceable (Closed)
Created 6 years, 8 months ago by Inactive
Modified 6 years, 8 months ago
Reviewers: arv (Not doing code reviews), tkent
Base URL: svn://svn.chromium.org/blink/trunk
Comments: 0
This is Rietveld
408576698