Issue 242613009: Make window.history property non replaceable

Issue 242613009: Make window.history property non replaceable (Closed)

Created:
6 years, 8 months ago by Inactive

Modified:
6 years, 8 months ago

Reviewers:
tkent, arv (Not doing code reviews)

CC:
blink-reviews, arv+blink, watchdog-blink-watchlist_google.com

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Make window.history property non replaceable Make window.history property non replaceable to match the specification: http://www.whatwg.org/specs/web-apps/current-work/multipage/browsers.html#window The new behavior also matches the behavior of Firefox 28 and IE11. R=arv@chromium.org, tkent@chromium.org BUG=365355 TEST=fast/dom/Window/get-set-properties.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172300

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -13 lines)			Patch
M	LayoutTests/fast/dom/Window/get-set-properties.html	View	1 2	2 chunks	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/dom/Window/get-set-properties-expected.txt	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	LayoutTests/fast/dom/Window/window-property-shadowing.html	View	1 2	1 chunk	+0 lines, -2 lines	0 comments	Download
M	LayoutTests/fast/dom/Window/window-property-shadowing-expected.txt	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	LayoutTests/fast/js/var-declarations-shadowing.html	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	LayoutTests/fast/js/var-declarations-shadowing-expected.txt	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	LayoutTests/http/tests/history/cross-origin-replace-history-object-child-expected.txt	View		1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/http/tests/history/resources/cross-origin-replaces-history-object-child-iframe.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/frame/Window.idl	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 9 (0 generated)

Inactive

This needs the following Chromium-side change to land before it can be committed: https://codereview.chromium.org/245443003/

6 years, 8 months ago (2014-04-22 13:12:13 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/242613009/40001

6 years, 8 months ago (2014-04-22 22:26:58 UTC) #4

Inactive

On 2014/04/22 22:51:33, Chris Dumez wrote: > The CQ bit was unchecked by mailto:ch.dumez@samsung.com Waiting ...

6 years, 8 months ago (2014-04-22 22:52:14 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/242613009/40001

6 years, 8 months ago (2014-04-23 00:09:00 UTC) #8

Message was sent while issue was closed.

Change committed as 172300