Chromium Code Reviews| Index: components/autofill/content/renderer/form_cache.h |
| diff --git a/components/autofill/content/renderer/form_cache.h b/components/autofill/content/renderer/form_cache.h |
| index 1f97d073137874e028a4a6e7b00a99eaede33a75..62cdda651f41707b7ae11af4e0cda37d7d835c8e 100644 |
| --- a/components/autofill/content/renderer/form_cache.h |
| +++ b/components/autofill/content/renderer/form_cache.h |
| @@ -31,20 +31,10 @@ class FormCache { |
| FormCache(); |
| ~FormCache(); |
| - // Scans the DOM in |frame| extracting and storing forms. |
| - // Fills |forms| with extracted forms. |
| - void ExtractForms(const blink::WebFrame& frame, |
| - std::vector<FormData>* forms); |
| - |
| - // Scans the DOM in |frame| extracting and storing forms. |
| - // Fills |forms| with extracted forms and |web_form_elements| with associated |
| - // web form elements. Returns true if there are unextracted forms due to |
| - // |minimum_required_fields| limit, else false. |
| - bool ExtractFormsAndFormElements( |
| - const blink::WebFrame& frame, |
| - size_t minimum_required_fields, |
| - std::vector<FormData>* forms, |
| - std::vector<blink::WebFormElement>* web_form_elements); |
| + // Scans the DOM in |frame| extracting and storing forms that have not been |
| + // seen before. Fills |forms| with extracted forms. |
| + void ExtractNewForms(const blink::WebFrame& frame, |
| + std::vector<FormData>* forms); |
| // Resets the forms for the specified |frame|. |
| void ResetFrame(const blink::WebFrame& frame); |
| @@ -63,6 +53,8 @@ class FormCache { |
| // The cached web frames. |
| std::set<blink::WebDocument> web_documents_; |
| + std::map<const blink::WebFrame*, std::set<FormData> > parsed_forms_; |
|
Ilya Sherman
2014/04/23 05:51:36
nit: Docs, please.
Garrett Casto
2014/04/23 21:51:14
Fixed.
|
| + |
| // The cached initial values for <select> elements. |
| std::map<const blink::WebSelectElement, base::string16> |
| initial_select_values_; |