Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Unified Diff: components/autofill/content/renderer/autofill_agent.h

Issue 242613006: [Autofill] Enable Autofill for dynamically created forms. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/autofill_agent.h
diff --git a/components/autofill/content/renderer/autofill_agent.h b/components/autofill/content/renderer/autofill_agent.h
index 5b268d9fdfea42dc6f3de494de468db26723586d..81047b205effb2409c563555f016a3bb4639ffc7 100644
--- a/components/autofill/content/renderer/autofill_agent.h
+++ b/components/autofill/content/renderer/autofill_agent.h
@@ -15,7 +15,6 @@
#include "base/timer/timer.h"
#include "components/autofill/content/renderer/form_cache.h"
#include "components/autofill/content/renderer/page_click_listener.h"
-#include "components/autofill/core/common/forms_seen_state.h"
#include "content/public/renderer/render_view_observer.h"
#include "third_party/WebKit/public/web/WebAutofillClient.h"
#include "third_party/WebKit/public/web/WebFormControlElement.h"
@@ -165,6 +164,9 @@ class AutofillAgent : public content::RenderViewObserver,
void PreviewFieldWithValue(const base::string16& value,
blink::WebInputElement* node);
+ // Notifies browser of new fillable forms in |frame|.
+ void ProcessForms(const blink::WebLocalFrame& frame);
+
// Hides any currently showing Autofill popup.
void HidePopup();
@@ -216,8 +218,10 @@ class AutofillAgent : public content::RenderViewObserver,
// messages to close the Autofill popup when it can't possibly be showing.
bool is_popup_possibly_visible_;
- // Timestamp of first time forms are seen.
- base::TimeTicks forms_seen_timestamp_;
+ // True if a message has already been sent about forms for the main frame.
+ // When the main frame is first loaded a message is sent even if no forms
Ilya Sherman 2014/04/23 05:51:36 nit: "first loaded a message" -> "first loaded, a
Garrett Casto 2014/04/23 21:51:14 Done.
+ // exist in the frame. Otherwise such messages are supressed.
Ilya Sherman 2014/04/23 05:51:36 nit: "Otherwise such messages" -> "Otherwise, such
Garrett Casto 2014/04/23 21:51:14 Done.
+ bool main_frame_processed_;
base::WeakPtrFactory<AutofillAgent> weak_ptr_factory_;

Powered by Google App Engine
This is Rietveld 408576698