[Autofill] Enable Autofill for dynamically created forms.

components/autofill/core/browser/autofill_manager.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/autofill_manager.h"
 
 #include <stddef.h>
 
 #include <limits>
 #include <map>
@@ skipping 285 matching lines @@
     driver_->GetBlockingPool()->PostTaskAndReply(
         FROM_HERE,
         base::Bind(&DeterminePossibleFieldTypesForUpload,
                    copied_profiles,
                    copied_credit_cards,
                    app_locale_,
                    raw_submitted_form),
         base::Bind(&AutofillManager::UploadFormDataAsyncCallback,
                    weak_ptr_factory_.GetWeakPtr(),
                    base::Owned(submitted_form.release()),
-                   forms_loaded_timestamp_,
+                   forms_loaded_timestamps_[form],
                    initial_interaction_timestamp_,
                    timestamp));
   }
 
   return true;
 }
 
 void AutofillManager::OnFormsSeen(const std::vector<FormData>& forms,
-                                  const TimeTicks& timestamp,
-                                  autofill::FormsSeenState state) {
+                                  const TimeTicks& timestamp) {
   if (!IsValidFormDataVector(forms))
     return;
 
-  bool is_post_document_load = state == autofill::DYNAMIC_FORMS_SEEN;
-  // If new forms were added dynamically, treat as a new page.
-  if (is_post_document_load)
-    Reset();
-
   if (!driver_->RendererIsAvailable())
     return;
 
   bool enabled = IsAutofillEnabled();
   if (!has_logged_autofill_enabled_) {
     metric_logger_->LogIsAutofillEnabledAtPageLoad(enabled);
     has_logged_autofill_enabled_ = true;
   }
 
   if (!enabled)
     return;
 
-  forms_loaded_timestamp_ = timestamp;
+  for (size_t i = 0; i < forms.size(); ++i)
+    forms_loaded_timestamps_[forms[i]] = timestamp;

[Ilya Sherman, 2014/04/25 00:43:02]

nit: I'd prefer that you add curly braces around the body of the loop, and
possibly leave a blank line below it as well.

[Garrett Casto, 2014/04/29 22:57:43]

Done.

   ParseForms(forms);
 }
 
 void AutofillManager::OnTextFieldDidChange(const FormData& form,
                                            const FormFieldData& field,
                                            const TimeTicks& timestamp) {
   if (!IsValidFormData(form) || !IsValidFormFieldData(field))
     return;
 
   FormStructure* form_structure = NULL;
@@ skipping 468 matching lines @@
 }
 
 void AutofillManager::Reset() {
   form_structures_.clear();
   has_logged_autofill_enabled_ = false;
   has_logged_address_suggestions_count_ = false;
   did_show_suggestions_ = false;
   user_did_type_ = false;
   user_did_autofill_ = false;
   user_did_edit_autofilled_field_ = false;
-  forms_loaded_timestamp_ = TimeTicks();
+  forms_loaded_timestamps_.clear();
   initial_interaction_timestamp_ = TimeTicks();
   external_delegate_->Reset();
 }
 
 AutofillManager::AutofillManager(AutofillDriver* driver,
                                  autofill::AutofillManagerDelegate* delegate,
                                  PersonalDataManager* personal_data)
     : driver_(driver),
       manager_delegate_(delegate),
       app_locale_("en-US"),
@@ skipping 330 matching lines @@
     return false;
 
   // Disregard forms that we wouldn't ever autofill in the first place.
   if (!form.ShouldBeParsed(true))
     return false;
 
   return true;
 }
 
 }  // namespace autofill