Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 242613005: iframe (Closed)

Created:
6 years, 8 months ago by jcgregorio
Modified:
6 years, 8 months ago
Reviewers:
mtklein
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Add support for serving up a view that can be iframed. Also add support for creating the <iframe /> code needed for embedding. This CL must land after https://codereview.chromium.org/240773003/ BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14266

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -15 lines) Patch
M experimental/webtry/TODO.md View 1 2 3 4 2 chunks +0 lines, -4 lines 0 comments Download
M experimental/webtry/css/webtry.css View 1 chunk +8 lines, -3 lines 0 comments Download
M experimental/webtry/js/run.js View 1 2 3 3 chunks +27 lines, -1 line 0 comments Download
A experimental/webtry/templates/iframe.html View 1 chunk +26 lines, -0 lines 0 comments Download
M experimental/webtry/templates/index.html View 1 2 3 2 chunks +7 lines, -3 lines 0 comments Download
M experimental/webtry/templates/workspace.html View 2 chunks +3 lines, -3 lines 0 comments Download
M experimental/webtry/webtry.go View 1 8 chunks +44 lines, -1 line 3 comments Download

Messages

Total messages: 7 (0 generated)
jcgregorio
6 years, 8 months ago (2014-04-18 16:34:16 UTC) #1
mtklein
lgtm https://codereview.chromium.org/242613005/diff/60001/experimental/webtry/webtry.go File experimental/webtry/webtry.go (right): https://codereview.chromium.org/242613005/diff/60001/experimental/webtry/webtry.go#newcode118 experimental/webtry/webtry.go:118: rand.Seed(time.Now().UnixNano()) Goes with the other CL?
6 years, 8 months ago (2014-04-18 16:43:55 UTC) #2
jcgregorio
https://codereview.chromium.org/242613005/diff/60001/experimental/webtry/webtry.go File experimental/webtry/webtry.go (right): https://codereview.chromium.org/242613005/diff/60001/experimental/webtry/webtry.go#newcode118 experimental/webtry/webtry.go:118: rand.Seed(time.Now().UnixNano()) Yeah, caught this in this CL. Since their ...
6 years, 8 months ago (2014-04-18 17:00:10 UTC) #3
mtklein
https://codereview.chromium.org/242613005/diff/60001/experimental/webtry/webtry.go File experimental/webtry/webtry.go (right): https://codereview.chromium.org/242613005/diff/60001/experimental/webtry/webtry.go#newcode118 experimental/webtry/webtry.go:118: rand.Seed(time.Now().UnixNano()) On 2014/04/18 17:00:11, jcgregorio wrote: > Yeah, caught ...
6 years, 8 months ago (2014-04-18 17:03:00 UTC) #4
jcgregorio
The CQ bit was checked by jcgregorio@google.com
6 years, 8 months ago (2014-04-19 14:07:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jcgregorio@google.com/242613005/60001
6 years, 8 months ago (2014-04-19 14:07:27 UTC) #6
commit-bot: I haz the power
6 years, 8 months ago (2014-04-19 14:50:27 UTC) #7
Message was sent while issue was closed. 
Change committed as 14266

Powered by Google App Engine
This is Rietveld 408576698