chrome/browser/extensions/extension_test_notification_observer.cc - Issue 242613004: Replace NOTIFICATION_EXTENSION_LOADED to NOTIFICATION_EXTENSION_LOADED_DEPRECATED

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_test_notification_observer.cc

Issue 242613004: Replace NOTIFICATION_EXTENSION_LOADED to NOTIFICATION_EXTENSION_LOADED_DEPRECATED (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_service_unittest.cc ('k') | chrome/browser/extensions/extension_toolbar_model.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_test_notification_observer.cc

diff --git a/chrome/browser/extensions/extension_test_notification_observer.cc b/chrome/browser/extensions/extension_test_notification_observer.cc

index c081e6406958a41b1e022bc0a6869282acefd9d5..6f8074aa24a9baccb4e02e7123df70bef10f96b9 100644

--- a/chrome/browser/extensions/extension_test_notification_observer.cc

+++ b/chrome/browser/extensions/extension_test_notification_observer.cc

@@ -198,7 +198,7 @@ bool ExtensionTestNotificationObserver::WaitForExtensionInstallError() {

}

void ExtensionTestNotificationObserver::WaitForExtensionLoad() {

- WaitForNotification(chrome::NOTIFICATION_EXTENSION_LOADED);

+ WaitForNotification(chrome::NOTIFICATION_EXTENSION_LOADED_DEPRECATED);

}

void ExtensionTestNotificationObserver::WaitForExtensionAndViewLoad() {

@@ -253,7 +253,7 @@ void ExtensionTestNotificationObserver::Observe(

const content::NotificationSource& source,

const content::NotificationDetails& details) {

switch (type) {

- case chrome::NOTIFICATION_EXTENSION_LOADED:

+ case chrome::NOTIFICATION_EXTENSION_LOADED_DEPRECATED:

sky 2014/04/18 14:11:49 If you're going to change this (which is good) fix

limasdf 2014/04/18 14:22:59 Done.

last_loaded_extension_id_ =

content::Details<const Extension>(details).ptr()->id();

VLOG(1) << "Got EXTENSION_LOADED notification.";

« no previous file with comments | « chrome/browser/extensions/extension_service_unittest.cc ('k') | chrome/browser/extensions/extension_toolbar_model.cc » ('j') | no next file with comments »