chrome/browser/extensions/api/location/location_manager.cc - Issue 242613004: Replace NOTIFICATION_EXTENSION_LOADED to NOTIFICATION_EXTENSION_LOADED_DEPRECATED

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/location/location_manager.cc

Issue 242613004: Replace NOTIFICATION_EXTENSION_LOADED to NOTIFICATION_EXTENSION_LOADED_DEPRECATED (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/input_ime/input_ime_api.cc ('k') | chrome/browser/extensions/api/management/management_api.cc » ('j') | chrome/browser/extensions/extension_test_notification_observer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/location/location_manager.cc

diff --git a/chrome/browser/extensions/api/location/location_manager.cc b/chrome/browser/extensions/api/location/location_manager.cc

index 35ed6346beb852909b6d190d2d03b004b72e7551..8867517f0746f5df0a676ed403edc17bd4853116 100644

--- a/chrome/browser/extensions/api/location/location_manager.cc

+++ b/chrome/browser/extensions/api/location/location_manager.cc

@@ -299,7 +299,8 @@ void LocationRequest::OnPositionReported(const content::Geoposition& position) {

LocationManager::LocationManager(content::BrowserContext* context)

: profile_(Profile::FromBrowserContext(context)) {

- registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_LOADED,

+ registrar_.Add(this,

+ chrome::NOTIFICATION_EXTENSION_LOADED_DEPRECATED,

content::Source<Profile>(profile_));

registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_UNLOADED_DEPRECATED,

content::Source<Profile>(profile_));

@@ -403,7 +404,7 @@ void LocationManager::Observe(int type,

DCHECK_CURRENTLY_ON(BrowserThread::UI);

switch (type) {

- case chrome::NOTIFICATION_EXTENSION_LOADED: {

+ case chrome::NOTIFICATION_EXTENSION_LOADED_DEPRECATED: {

// Grants permission to use geolocation once an extension with "location"

// permission is loaded.

const Extension* extension =