Specify a default display UI scale to reset the zoom to

Specify a default display UI scale to reset the zoom to

For devices with 1.25 DSF, pressing Ctrl+Shift+0 used to reset zoom to
a full HD scale (1.0 = 1920x1080), which is not the default scale we decided for
these devices (0.8 = 1536x864).

This CL marks one of the modes as the default one, and use that default mode to
reset the scale to.

BUG=chrome-os-partner:58181
TEST=on an elm device, pressing Ctrl+Shift+0, the scale should remain at 1536x864.
TEST=ash_unittests --gtest_filter=DisplayManagerTest.ResetInternalDisplayZoomFor1_25x*

Committed: https://crrev.com/8571a9c3216de20afa714851c2268edb52f43a8d
Cr-Commit-Position: refs/heads/master@{#427837}

[afakhry, 2016-10-19 18:22:10]

Description was changed from

==========
[WIP] Mark a default UI scale factor

BUG=chrome-os-partner:58181
==========

to

==========
Specify a default display UI scale to reset the zoom to

For devices with 1.25 DSF, pressing Ctrl+Shift+0 used to reset zoom to
a full HD scale (1.0 = 1920x1080), which is not the default scale we decided for
these devices (0.8 = 1536x864).

This CL marks one of the modes as the default one, and use that default mode to
reset the scale to.

BUG=chrome-os-partner:58181
TEST=on an elm device, pressing Ctrl+Shift+0, the scale should remain at
1536x864.
==========

[afakhry, 2016-10-19 18:22:24]

The CQ bit was checked by afakhry@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 18:22:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[afakhry, 2016-10-19 19:42:01]

afakhry@chromium.org changed reviewers:
+ oshima@chromium.org

[afakhry, 2016-10-19 19:42:02]

Oshima, please take a look. Thank you!

[commit-bot: I haz the power, 2016-10-19 20:44:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 20:44:39]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[oshima, 2016-10-19 21:04:06]

can you add a unit test? (DisplayManagerTest has several that tests ui scale)

https://codereview.chromium.org/2426103004/diff/20001/ash/display/display_man...
File ash/display/display_manager.cc (right):

https://codereview.chromium.org/2426103004/diff/20001/ash/display/display_man...
ash/display/display_manager.cc:1114: bool
DisplayManager::SetDisplayUIScale(int64_t id, float ui_scale) {
I believe we don't need this other than for tests. Can you move this to test
API?

https://codereview.chromium.org/2426103004/diff/20001/ash/display/display_man...
ash/display/display_manager.cc:1128: if (!IsActiveDisplayId(display_id))
Check internal display as well.

https://codereview.chromium.org/2426103004/diff/20001/ui/display/manager/mana...
File ui/display/manager/managed_display_info.cc (right):

https://codereview.chromium.org/2426103004/diff/20001/ui/display/manager/mana...
ui/display/manager/managed_display_info.cc:82: is_default_(false),
just initialize it in line because it's always false.

[afakhry, 2016-10-22 01:18:09]

The CQ bit was checked by afakhry@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-22 01:19:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-22 02:24:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-22 02:24:07]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[afakhry, 2016-10-24 15:55:06]

The CQ bit was checked by afakhry@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-24 15:55:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[afakhry, 2016-10-24 20:19:39]

The CQ bit was checked by afakhry@chromium.org to run a CQ dry run

[afakhry, 2016-10-24 20:20:24]

Description was changed from

==========
Specify a default display UI scale to reset the zoom to

For devices with 1.25 DSF, pressing Ctrl+Shift+0 used to reset zoom to
a full HD scale (1.0 = 1920x1080), which is not the default scale we decided for
these devices (0.8 = 1536x864).

This CL marks one of the modes as the default one, and use that default mode to
reset the scale to.

BUG=chrome-os-partner:58181
TEST=on an elm device, pressing Ctrl+Shift+0, the scale should remain at
1536x864.
==========

to

==========
Specify a default display UI scale to reset the zoom to

For devices with 1.25 DSF, pressing Ctrl+Shift+0 used to reset zoom to
a full HD scale (1.0 = 1920x1080), which is not the default scale we decided for
these devices (0.8 = 1536x864).

This CL marks one of the modes as the default one, and use that default mode to
reset the scale to.

BUG=chrome-os-partner:58181
TEST=on an elm device, pressing Ctrl+Shift+0, the scale should remain at
1536x864.
TEST=ash_unittests
--gtest_filter=DisplayManagerTest.ResetInternalDisplayZoomFor1_25x*
==========

[commit-bot: I haz the power, 2016-10-24 20:20:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[afakhry, 2016-10-24 20:21:46]

Working test. PTAL.

https://codereview.chromium.org/2426103004/diff/20001/ash/display/display_man...
File ash/display/display_manager.cc (right):

https://codereview.chromium.org/2426103004/diff/20001/ash/display/display_man...
ash/display/display_manager.cc:1114: bool
DisplayManager::SetDisplayUIScale(int64_t id, float ui_scale) {
On 2016/10/19 21:04:06, oshima wrote:
> I believe we don't need this other than for tests. Can you move this to test
> API?

Done.

https://codereview.chromium.org/2426103004/diff/20001/ash/display/display_man...
ash/display/display_manager.cc:1128: if (!IsActiveDisplayId(display_id))
On 2016/10/19 21:04:06, oshima wrote:
> Check internal display as well.

Done.

https://codereview.chromium.org/2426103004/diff/20001/ui/display/manager/mana...
File ui/display/manager/managed_display_info.cc (right):

https://codereview.chromium.org/2426103004/diff/20001/ui/display/manager/mana...
ui/display/manager/managed_display_info.cc:82: is_default_(false),
On 2016/10/19 21:04:06, oshima wrote:
> just initialize it in line because it's always false.

Done.

[commit-bot: I haz the power, 2016-10-25 01:09:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 01:09:45]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[afakhry, 2016-10-25 20:20:11]

Oshima, friendly ping.

[oshima, 2016-10-25 21:13:48]

lgtm with nit.

https://codereview.chromium.org/2426103004/diff/80001/ash/display/display_man...
File ash/display/display_manager_unittest.cc (right):

https://codereview.chromium.org/2426103004/diff/80001/ash/display/display_man...
ash/display/display_manager_unittest.cc:1352: new
display::ManagedDisplayMode(gfx::Size(2400, 1350), 60.0f,
you can create this on stack.

[afakhry, 2016-10-25 23:46:55]

https://codereview.chromium.org/2426103004/diff/80001/ash/display/display_man...
File ash/display/display_manager_unittest.cc (right):

https://codereview.chromium.org/2426103004/diff/80001/ash/display/display_man...
ash/display/display_manager_unittest.cc:1352: new
display::ManagedDisplayMode(gfx::Size(2400, 1350), 60.0f,
On 2016/10/25 21:13:48, oshima wrote:
> you can create this on stack.

display::ManagedDisplayMode is base::RefCounted with a private destructor. I
just removed the reference, so it becomes 

const scoped_refptr<display::ManagedDisplayMode> base_mode(...)
instead of
const scoped_refptr<display::ManagedDisplayMode>& base_mode(...)

[afakhry, 2016-10-26 21:03:38]

The CQ bit was checked by afakhry@chromium.org

[commit-bot: I haz the power, 2016-10-26 21:04:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 22:04:03]

Description was changed from

==========
Specify a default display UI scale to reset the zoom to

For devices with 1.25 DSF, pressing Ctrl+Shift+0 used to reset zoom to
a full HD scale (1.0 = 1920x1080), which is not the default scale we decided for
these devices (0.8 = 1536x864).

This CL marks one of the modes as the default one, and use that default mode to
reset the scale to.

BUG=chrome-os-partner:58181
TEST=on an elm device, pressing Ctrl+Shift+0, the scale should remain at
1536x864.
TEST=ash_unittests
--gtest_filter=DisplayManagerTest.ResetInternalDisplayZoomFor1_25x*
==========

to

==========
Specify a default display UI scale to reset the zoom to

For devices with 1.25 DSF, pressing Ctrl+Shift+0 used to reset zoom to
a full HD scale (1.0 = 1920x1080), which is not the default scale we decided for
these devices (0.8 = 1536x864).

This CL marks one of the modes as the default one, and use that default mode to
reset the scale to.

BUG=chrome-os-partner:58181
TEST=on an elm device, pressing Ctrl+Shift+0, the scale should remain at
1536x864.
TEST=ash_unittests
--gtest_filter=DisplayManagerTest.ResetInternalDisplayZoomFor1_25x*
==========

[commit-bot: I haz the power, 2016-10-26 22:04:04]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-10-26 22:06:08]

Description was changed from

==========
Specify a default display UI scale to reset the zoom to

For devices with 1.25 DSF, pressing Ctrl+Shift+0 used to reset zoom to
a full HD scale (1.0 = 1920x1080), which is not the default scale we decided for
these devices (0.8 = 1536x864).

This CL marks one of the modes as the default one, and use that default mode to
reset the scale to.

BUG=chrome-os-partner:58181
TEST=on an elm device, pressing Ctrl+Shift+0, the scale should remain at
1536x864.
TEST=ash_unittests
--gtest_filter=DisplayManagerTest.ResetInternalDisplayZoomFor1_25x*
==========

to

==========
Specify a default display UI scale to reset the zoom to

For devices with 1.25 DSF, pressing Ctrl+Shift+0 used to reset zoom to
a full HD scale (1.0 = 1920x1080), which is not the default scale we decided for
these devices (0.8 = 1536x864).

This CL marks one of the modes as the default one, and use that default mode to
reset the scale to.

BUG=chrome-os-partner:58181
TEST=on an elm device, pressing Ctrl+Shift+0, the scale should remain at
1536x864.
TEST=ash_unittests
--gtest_filter=DisplayManagerTest.ResetInternalDisplayZoomFor1_25x*

Committed: https://crrev.com/8571a9c3216de20afa714851c2268edb52f43a8d
Cr-Commit-Position: refs/heads/master@{#427837}
==========

[commit-bot: I haz the power, 2016-10-26 22:06:09]

Patchset 6 (id:??) landed as
https://crrev.com/8571a9c3216de20afa714851c2268edb52f43a8d
Cr-Commit-Position: refs/heads/master@{#427837}