Chromium Code Reviews| Index: runtime/bin/file.h |
| diff --git a/runtime/bin/file.h b/runtime/bin/file.h |
| index c30c02d8bf2d68874601cc4d073d9f09644543e2..cef6f0a56594ce645dfadce15ba269ec8ada5b68 100644 |
| --- a/runtime/bin/file.h |
| +++ b/runtime/bin/file.h |
| @@ -162,6 +162,10 @@ class File : public ReferenceCounted<File> { |
| // Like ScopedOpen(), but no API scope is needed. |
| static File* Open(const char* path, FileOpenMode mode); |
| + // Caution! On Windows, the static functions below may call |
| + // Dart_ScopeAllocate() to do string conversions! If you call these functions |
| + // without a scope, they will fail on Windows! |
|
siva
2016/10/18 17:32:20
GetType is in this list but it does not call Dart_
|
| + |
| // Create a file object for the specified stdio file descriptor |
| // (stdin, stout or stderr). |
| static File* OpenStdio(int fd); |