Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2426013002: Add Swarming magic environment variables to ENV_WHITELIST (Closed)

Created:
4 years, 2 months ago by borenet2
Modified:
4 years, 2 months ago
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add Swarming magic environment variables to ENV_WHITELIST BUG= Committed: https://github.com/luci/recipes-py/commit/9d854c6e7ce9ed004ef0854d0d2c3c5aabcca66f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M recipe_engine/run.py View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
borenet
4 years, 2 months ago (2016-10-18 15:32:32 UTC) #2
martiniss
are these documented anywhere?
4 years, 2 months ago (2016-10-18 20:54:18 UTC) #3
Vadim Sh.
On 2016/10/18 20:54:18, martiniss wrote: > are these documented anywhere? https://github.com/luci/luci-py/blob/master/appengine/swarming/doc/Magic-Values.md#swarming
4 years, 2 months ago (2016-10-18 21:46:26 UTC) #4
martiniss
lgtm
4 years, 2 months ago (2016-10-18 21:49:27 UTC) #5
borenet
Yep, sorry forgot to add that link initially.
4 years, 2 months ago (2016-10-19 15:01:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2426013002/1
4 years, 2 months ago (2016-10-19 15:01:58 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-19 15:04:53 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://github.com/luci/recipes-py/commit/9d854c6e7ce9ed004ef0854d0d2c3c5aabc...

Powered by Google App Engine
This is Rietveld 408576698