Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2425933002: Revert "Change TypeInference to handle super calls as direct invocations." and "Optimize needNoSuch… (Closed)

Created:
4 years, 2 months ago by Johnni Winther
Modified:
4 years, 2 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Change TypeInference to handle super calls as direct invocations." and "Optimize needNoSuchMethodHandling computation" This reverts commit 70159b741886b0bb10c3c6f77d7a0d0109131320. This reverts commit a8b2bfb5eb77f670c414069dd9ff3dfaa993a3a8. Committed: https://github.com/dart-lang/sdk/commit/5397c5427e9102a8ea7602174be2664d4c15bb8b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -500 lines) Patch
M pkg/compiler/lib/src/elements/common.dart View 1 chunk +4 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 1 chunk +1 line, -7 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/inferrer_visitor.dart View 2 chunks +8 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart View 11 chunks +27 lines, -354 lines 0 comments Download
M pkg/compiler/lib/src/ssa/codegen.dart View 2 chunks +8 lines, -35 lines 0 comments Download
M pkg/compiler/lib/src/ssa/optimize.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/universe/class_set.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/universe/function_set.dart View 1 chunk +2 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/universe/use.dart View 1 chunk +0 lines, -27 lines 0 comments Download
M pkg/compiler/lib/src/universe/world_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/world.dart View 2 chunks +26 lines, -43 lines 0 comments Download
M tests/compiler/dart2js/needs_no_such_method_test.dart View 5 chunks +18 lines, -15 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
Johnni Winther
TBR
4 years, 2 months ago (2016-10-18 09:00:28 UTC) #2
Johnni Winther
4 years, 2 months ago (2016-10-18 09:02:14 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
5397c5427e9102a8ea7602174be2664d4c15bb8b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698