Land Recent QUIC Changes.

Land Recent QUIC Changes.

Disable QuicFlowController for QUIC versions < QUIC_VERSION_17

Chrome Beta was happily advertising a flow control receive window of
length 0, under the assumption that because the version of QUIC being
spoken didn't support flow control, a zero length window advertisement
would have no adverse effects.

On the server end, the refactoring in internal change: 64733866 resulted
in the QUIC version not being checked when querying
QuicFlowController::IsBlocked. IsBlocked would look at the client's
advertised receive window, and conclude that no data could be sent. This
would never change as the flow control accounting is protected behind
version checks.

Ultimately this means that once a stream was marked as write blocked, it
would never resume writing:

https://codereview.chromium.org/242453002/diff/1/net/quic/quic_session.cc?context=&column_width=80
(line# 286) resulting in a connection timeout.

This CL explicitly disables the QuicFlowController when the negotiated
QUIC version is < QUIC_VERSION_17.

Merge internal change: 65137349

This internal change was LGTM'ed by rch. Wanted to port this change
to disable flow control.

https://codereview.chromium.org/242583002/


Downgrading rst stream codes which wouldn't be recognized by the peer.

chromium: fixed chromium's unit tests to use AdjustErrorForVersion.

Merge internal change: 64783797
https://codereview.chromium.org/242483002/


Added WriteResult::WriteResult method for internal use.

Merge internal change: 64780998
https://codereview.chromium.org/242293003/


QUIC: When sending a RST stream for flow control accounting purposes,
include a more descriptive error code.

Prompted by alyssar's comment in internal change: 61236803

Chromium specific code:
+ deleted unused ConstructRstPacket method from
QuicNetworkTransactionTest.
+ Changed ConstructRstPacket to use the new descriptive error code.

Merge internal change: 64774941
https://codereview.chromium.org/242093003/


Pull out flow control functionality from ReliableQuicStream into a new
class, QuicFlowController.

Without this refactoring, all the accounting of bytes
sent/buffered/consumed, comparisons of these with limits to decide if
blocked or not, will be duplicated in ReliableQuicStream and
QuicConnection. Putting all this in a new class means it's easier to
have more comprehensive testing, simplifies ReliableQuicStream, and will
make it much easier to add Connection level flow control (work in
progress internal change: 63944402).

Refactor of QUIC stream flow control. No behavior change, still
protected behind FLAGS_enable_quic_stream_flow_control. This flag is
currently disabled.

Merge internal change: 64733866
https://codereview.chromium.org/242453002/


Plumbs through delta_largest_observed from
QuicSentPackerManager::HandleAckForSentPacket, up to the
QuicAckNotifier. Eventually these values get to the
QuicFasterStatsGatherer which now performs a more accurate RT
calculation.

The important changes are in QuicSentPacketManager (pulling the delta
out of ReceivedInfo), and in QuicFasterStatsGatherer (doing the new
calculation of RT). The rest is plumbing and updating tests.

Improve accuracy of QUIC FasterStats RT calculation by using the
delta time included with delayed ACKs.

Merge internal change: 64721749
https://codereview.chromium.org/241783002/


Fixed a bug in QuicPacketCreator when FEC was used for unsupported
versions, and made packet_creator tests run across all supported
versions of QUIC.

Merge internal change: 64701677
https://codereview.chromium.org/241483004/


Fix to ensure hybrid slow start is reset when QUIC's retransmission
timer fires.

Merge internal change: 64698621
https://codereview.chromium.org/241563002/

R=rch@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264889

[Ryan Hamilton, 2014-04-18 03:40:29]

lgtm

[Ryan Hamilton, 2014-04-18 03:47:35]

We probably don't want to land this until we've made sure the flow control
situation is all squared away tomorrow.

[ramant (doing other things), 2014-04-18 03:48:22]

On 2014/04/18 03:47:35, Ryan Hamilton wrote:
> We probably don't want to land this until we've made sure the flow control
> situation is all squared away tomorrow.

Sounds great. I won't commit it.

thanks,
raman

[ramant (doing other things), 2014-04-18 21:50:15]

The CQ bit was checked by rtenneti@chromium.org

[commit-bot: I haz the power, 2014-04-18 21:50:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rtenneti@chromium.org/242593002/60001

[commit-bot: I haz the power, 2014-04-18 22:06:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-18 22:06:35]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_gn_rel

[ramant (doing other things), 2014-04-18 22:12:40]

The CQ bit was checked by rtenneti@chromium.org

[commit-bot: I haz the power, 2014-04-18 22:12:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rtenneti@chromium.org/242593002/60001

[commit-bot: I haz the power, 2014-04-18 23:44:40]

Change committed as 264889