cc/surfaces/surface_sequence.h - Issue 2425923003: Replaced is_null() with is_valid in SurfaceId and related classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/surfaces/surface_sequence.h

Issue 2425923003: Replaced is_null() with is_valid in SurfaceId and related classes. (Closed)

Patch Set: Rebase Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/surfaces/surface_sequence.h

diff --git a/cc/surfaces/surface_sequence.h b/cc/surfaces/surface_sequence.h

index f847d0b53386764b8616a2fd0321078b70d17336..3437394c77933d0cd8d22478bbee35e7b646e077 100644

--- a/cc/surfaces/surface_sequence.h

+++ b/cc/surfaces/surface_sequence.h

@@ -22,7 +22,7 @@ struct SurfaceSequence {

SurfaceSequence() : sequence(0u) {}

SurfaceSequence(const FrameSinkId& frame_sink_id, uint32_t sequence)

: frame_sink_id(frame_sink_id), sequence(sequence) {}

- bool is_null() const { return frame_sink_id.is_null() && sequence == 0u; }

+ bool is_valid() const { return frame_sink_id.is_valid() && sequence > 0u; }

FrameSinkId frame_sink_id;

uint32_t sequence;

« no previous file with comments | « cc/surfaces/surface_id.h ('k') | cc/test/test_compositor_frame_sink.cc » ('j') | no next file with comments »