Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: cc/surfaces/surface_sequence.h

Issue 2425923003: Replaced is_null() with is_valid in SurfaceId and related classes. (Closed)
Patch Set: Fixed an exo compile error Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« cc/surfaces/surface_id.h ('K') | « cc/surfaces/surface_id.h ('k') | cc/test/test_compositor_frame_sink.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/surfaces/surface_sequence.h
diff --git a/cc/surfaces/surface_sequence.h b/cc/surfaces/surface_sequence.h
index f847d0b53386764b8616a2fd0321078b70d17336..3437394c77933d0cd8d22478bbee35e7b646e077 100644
--- a/cc/surfaces/surface_sequence.h
+++ b/cc/surfaces/surface_sequence.h
@@ -22,7 +22,7 @@ struct SurfaceSequence {
SurfaceSequence() : sequence(0u) {}
SurfaceSequence(const FrameSinkId& frame_sink_id, uint32_t sequence)
: frame_sink_id(frame_sink_id), sequence(sequence) {}
- bool is_null() const { return frame_sink_id.is_null() && sequence == 0u; }
+ bool is_valid() const { return frame_sink_id.is_valid() && sequence > 0u; }
piman 2016/11/08 23:16:34 Ditto, this changes the logic. Is that intended?
Alex Z. 2016/11/09 15:29:15 Yes. I will update the description to reflex the c
FrameSinkId frame_sink_id;
uint32_t sequence;
« cc/surfaces/surface_id.h ('K') | « cc/surfaces/surface_id.h ('k') | cc/test/test_compositor_frame_sink.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698