content/test/content_browser_test_utils_internal.cc - Issue 2425923003: Replaced is_null() with is_valid in SurfaceId and related classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/test/content_browser_test_utils_internal.cc

Issue 2425923003: Replaced is_null() with is_valid in SurfaceId and related classes. (Closed)

Patch Set: Removed added printf statements; LocalFrameId::is_valid() no longer checks if nonce is 0. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/test/content_browser_test_utils_internal.cc

diff --git a/content/test/content_browser_test_utils_internal.cc b/content/test/content_browser_test_utils_internal.cc

index d3af538759c0d9d386e256d79e2e8770a202d622..646ba23503726654a8ede7770d04825834b3cca8 100644

--- a/content/test/content_browser_test_utils_internal.cc

+++ b/content/test/content_browser_test_utils_internal.cc

@@ -320,7 +320,7 @@ void SurfaceHitTestReadyNotifier::WaitForSurfaceReady() {

bool SurfaceHitTestReadyNotifier::ContainsSurfaceId(

cc::SurfaceId container_surface_id) {

- if (container_surface_id.is_null())

+ if (!container_surface_id.is_valid())

return false;

for (cc::SurfaceId id :

surface_manager_->GetSurfaceForId(container_surface_id)