content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc - Issue 2425923003: Replaced is_null() with is_valid in SurfaceId and related classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc

Issue 2425923003: Replaced is_null() with is_valid in SurfaceId and related classes. (Closed)

Patch Set: Removed added printf statements; LocalFrameId::is_valid() no longer checks if nonce is 0. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« cc/surfaces/local_frame_id.h ('K') | « content/browser/frame_host/render_widget_host_view_child_frame.cc ('k') | content/browser/frame_host/render_widget_host_view_guest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc

diff --git a/content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc b/content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc

index 62a75b44458a0368f781bbcdcc53d0f2a1242bdf..996f6e402a00dafbd10e4912d49cb754b98b65b1 100644

--- a/content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc

+++ b/content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc

@@ -180,7 +180,7 @@ TEST_F(RenderWidgetHostViewChildFrameTest, SwapCompositorFrame) {

0, CreateDelegatedFrame(scale_factor, view_size, view_rect));

cc::SurfaceId id = GetSurfaceId();

- if (!id.is_null()) {

+ if (id.is_valid()) {

#if !defined(OS_ANDROID)

ImageTransportFactory* factory = ImageTransportFactory::GetInstance();

cc::SurfaceManager* manager = factory->GetSurfaceManager();