cc/surfaces/frame_sink_id.h - Issue 2425923003: Replaced is_null() with is_valid in SurfaceId and related classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/surfaces/frame_sink_id.h

Issue 2425923003: Replaced is_null() with is_valid in SurfaceId and related classes. (Closed)

Patch Set: Removed added printf statements; LocalFrameId::is_valid() no longer checks if nonce is 0. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/surfaces/frame_sink_id.h

diff --git a/cc/surfaces/frame_sink_id.h b/cc/surfaces/frame_sink_id.h

index b8f3675fd21f3ea4eba08eea2843affc876c035a..a22aa08dba128fda4785984d4668a978b22f020a 100644

--- a/cc/surfaces/frame_sink_id.h

+++ b/cc/surfaces/frame_sink_id.h

@@ -23,6 +23,8 @@ class FrameSinkId {

constexpr FrameSinkId(uint32_t client_id, uint32_t sink_id)

: client_id_(client_id), sink_id_(sink_id) {}

+ constexpr bool is_valid() const { return client_id_ != 0 || sink_id_ != 0; }

constexpr bool is_null() const { return client_id_ == 0 && sink_id_ == 0; }

constexpr uint32_t client_id() const { return client_id_; }