Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Side by Side Diff: ui/android/delegated_frame_host_android.cc

Issue 2425923003: Replaced is_null() with is_valid in SurfaceId and related classes. (Closed)
Patch Set: Rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « services/ui/ws/server_window_compositor_frame_sink.cc ('k') | ui/aura/mus/window_port_mus.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/android/delegated_frame_host_android.h" 5 #include "ui/android/delegated_frame_host_android.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "cc/layers/solid_color_layer.h" 9 #include "cc/layers/solid_color_layer.h"
10 #include "cc/layers/surface_layer.h" 10 #include "cc/layers/surface_layer.h"
(...skipping 203 matching lines...) Expand 10 before | Expand all | Expand 10 after
214 void DelegatedFrameHostAndroid::UpdateContainerSizeinDIP( 214 void DelegatedFrameHostAndroid::UpdateContainerSizeinDIP(
215 const gfx::Size& size_in_dip) { 215 const gfx::Size& size_in_dip) {
216 container_size_in_dip_ = size_in_dip; 216 container_size_in_dip_ = size_in_dip;
217 background_layer_->SetBounds(gfx::ConvertSizeToPixel( 217 background_layer_->SetBounds(gfx::ConvertSizeToPixel(
218 gfx::DeviceDisplayInfo().GetDIPScale(), container_size_in_dip_)); 218 gfx::DeviceDisplayInfo().GetDIPScale(), container_size_in_dip_));
219 UpdateBackgroundLayer(); 219 UpdateBackgroundLayer();
220 } 220 }
221 221
222 void DelegatedFrameHostAndroid::RegisterFrameSinkHierarchy( 222 void DelegatedFrameHostAndroid::RegisterFrameSinkHierarchy(
223 const cc::FrameSinkId& parent_id) { 223 const cc::FrameSinkId& parent_id) {
224 if (!registered_parent_frame_sink_id_.is_null()) 224 if (registered_parent_frame_sink_id_.is_valid())
225 UnregisterFrameSinkHierarchy(); 225 UnregisterFrameSinkHierarchy();
226 registered_parent_frame_sink_id_ = parent_id; 226 registered_parent_frame_sink_id_ = parent_id;
227 surface_manager_->RegisterSurfaceFactoryClient(frame_sink_id_, this); 227 surface_manager_->RegisterSurfaceFactoryClient(frame_sink_id_, this);
228 surface_manager_->RegisterFrameSinkHierarchy(parent_id, frame_sink_id_); 228 surface_manager_->RegisterFrameSinkHierarchy(parent_id, frame_sink_id_);
229 } 229 }
230 230
231 void DelegatedFrameHostAndroid::UnregisterFrameSinkHierarchy() { 231 void DelegatedFrameHostAndroid::UnregisterFrameSinkHierarchy() {
232 if (registered_parent_frame_sink_id_.is_null()) 232 if (!registered_parent_frame_sink_id_.is_valid())
233 return; 233 return;
234 surface_manager_->UnregisterSurfaceFactoryClient(frame_sink_id_); 234 surface_manager_->UnregisterSurfaceFactoryClient(frame_sink_id_);
235 surface_manager_->UnregisterFrameSinkHierarchy( 235 surface_manager_->UnregisterFrameSinkHierarchy(
236 registered_parent_frame_sink_id_, frame_sink_id_); 236 registered_parent_frame_sink_id_, frame_sink_id_);
237 registered_parent_frame_sink_id_ = cc::FrameSinkId(); 237 registered_parent_frame_sink_id_ = cc::FrameSinkId();
238 } 238 }
239 239
240 void DelegatedFrameHostAndroid::ReturnResources( 240 void DelegatedFrameHostAndroid::ReturnResources(
241 const cc::ReturnedResourceArray& resources) { 241 const cc::ReturnedResourceArray& resources) {
242 return_resources_callback_.Run(resources); 242 return_resources_callback_.Run(resources);
(...skipping 20 matching lines...) Expand all
263 content_size_in_dip.width() < container_size_in_dip_.width() || 263 content_size_in_dip.width() < container_size_in_dip_.width() ||
264 content_size_in_dip.height() < container_size_in_dip_.height(); 264 content_size_in_dip.height() < container_size_in_dip_.height();
265 } else { 265 } else {
266 background_is_drawable = true; 266 background_is_drawable = true;
267 } 267 }
268 268
269 background_layer_->SetIsDrawable(background_is_drawable); 269 background_layer_->SetIsDrawable(background_is_drawable);
270 } 270 }
271 271
272 } // namespace ui 272 } // namespace ui
OLDNEW
« no previous file with comments | « services/ui/ws/server_window_compositor_frame_sink.cc ('k') | ui/aura/mus/window_port_mus.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698